Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for PopperInstance before destroying it #597

Merged
merged 1 commit into from Nov 29, 2021

Conversation

MathiasWP
Copy link
Contributor

I got this error:

Screenshot 2021-11-29 at 14 52 07

Saw that it was connected to this piece of code:

Screenshot 2021-11-29 at 14 52 33

And if i understand this correctly, then it is valid that this.popover can be undefined when calling disconnectedCallback, because it is asynchronously created.

Screenshot 2021-11-29 at 14 56 44

I therefore added this check in the disconnectedCallback method in the dropdown.ts file.

Screenshot 2021-11-29 at 14 55 35

@vercel
Copy link

vercel bot commented Nov 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shoelace/shoelace/3ytBTSDcZGwfU8SjAPrwDU9pHNZn
✅ Preview: https://shoelace-git-fork-mathiaswp-next-shoelace.vercel.app

@claviska
Copy link
Member

Thanks. This is what's happening in tooltip, so makes sense to add it here.

@claviska claviska merged commit 194c190 into shoelace-style:next Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants