Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(split-panel): add missing keys #629

Merged
merged 2 commits into from Dec 27, 2021
Merged

Conversation

davidglezz
Copy link
Contributor

@davidglezz davidglezz commented Dec 23, 2021

ArrowUp and ArrowDown are used inside the if

@vercel
Copy link

vercel bot commented Dec 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shoelace/shoelace/DxmUyG8kHbzBfBc1QdgWuR1rbHtK
✅ Preview: https://shoelace-git-fork-davidglezz-patch-2-shoelace.vercel.app

@claviska
Copy link
Member

Whoops, nice catch. These were part of the original version and I forgot them when I rewrote it.

Can we make up/down only apply with the vertical orientation and left/right only apply when it’s not vertical?

Thanks!

@davidglezz
Copy link
Contributor Author

davidglezz commented Dec 24, 2021

Can we make up/down only apply with the vertical orientation and left/right only apply when it’s not vertical?

The previous code already does this, but preventDefault was always called so I have updated the code, now it only does preventDefault when the key changes the percentage.

Copy link
Member

@claviska claviska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@claviska claviska merged commit 218f6cb into shoelace-style:next Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants