Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (dropdown): tolerate dropdowns without menus #721

Merged
merged 1 commit into from Apr 6, 2022

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Apr 5, 2022

Fixes #719

I basically reshuffled the logic so:

  • Without a menu child, esc will still close the dropdown
  • Without a menu child, space/enter will still open the dropdown
  • Arrow navigation will only open the dropdown and try interact with it if you have a menu

FYI there is a skipped test in here which uncovered another bug: #720

@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shoelace/shoelace/GPaBTJfUp9tvVHU6VS7JRs6W9LeP
✅ Preview: https://shoelace-git-fork-43081j-dropdown-without-menu-shoelace.vercel.app

@claviska
Copy link
Member

claviska commented Apr 6, 2022

Nice catch, and thanks for the tests!

@43081j 43081j deleted the dropdown-without-menu branch April 6, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color Picker throws console error on trigger keydown
2 participants