Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditLine is misaligned #347

Open
IanTrudel opened this issue Mar 30, 2017 · 5 comments
Open

EditLine is misaligned #347

IanTrudel opened this issue Mar 30, 2017 · 5 comments

Comments

@IanTrudel
Copy link
Collaborator

IanTrudel commented Mar 30, 2017

EditLine is slightly up compared to other side-by-side widgets. Other EditBox and such may suffer from this too.

image

@ccoupe
Copy link

ccoupe commented Mar 31, 2017

It's theme 'enhancement`. The top line is fine on Linux (two different themes/platorms) and if I remember OSX, the edit_line is less tall than the buttons. The cobbler code could use some margins/centering between the buttons and the edit line to better fit the horizontal space which would hide the themes 'help', and would look better for all.

@IanTrudel
Copy link
Collaborator Author

It's not correct as far as Windows theme goes. There is 1px difference. The second flow below would be the expected behaviour.

image

Shoes.app(width: 350, height: 150) do
   para "———————————————————\n"
   
   flow do
      button "one"
      edit_line
      button "two"
   end
   
   para "———————————————————\n"
   
   flow do
      button "one"
      edit_line margin: 1
      button "two"
   end
end

@ccoupe
Copy link

ccoupe commented Apr 1, 2017

Why do you believe buttons are the same height as edit_lines? They are not even close to the same height on OSX. Adding that margin would ruin the OSX layout. Fix the Windows theme.

@IanTrudel
Copy link
Collaborator Author

Fix the Windows theme.

Yes, seems like the logical thing to do.

@IanTrudel
Copy link
Collaborator Author

Same misalignment problem on FreeBSD.

Shoes:
image

FCITX Configuration (QT):
image

Characters table (GTK)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants