Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Always set up Bundler" #1208

Merged
merged 1 commit into from Dec 14, 2015

Conversation

jasonrclark
Copy link
Member

Reverts #1189

jasonrclark added a commit that referenced this pull request Dec 14, 2015
@jasonrclark jasonrclark merged commit aacac8a into master Dec 14, 2015
@jasonrclark jasonrclark deleted the revert-1189-jclark/require-bundler branch December 14, 2015 07:11
@jasonrclark jasonrclark restored the revert-1189-jclark/require-bundler branch December 14, 2015 07:12
@PragTob
Copy link
Member

PragTob commented Dec 14, 2015

.@jasonrclark from over at #1189 (for less jumping):

Turns out this was a very, very bad idea. This makes it so shoes won't execute from a directory that doesn't have a Gemfile with shoes in it, which is definitely not what we want.

Will need to just look harder at this to resolve more systematically for #1148 later but gonna revert for pre5

I personally have no idea why that'd cause it (unless we need the bundler code anywhere else, in which case maybe bundler should be an explicit dependency) - but for now Jason deserves some sleep and I go to work :)

@jasonrclark
Copy link
Member Author

The problem is that require 'bundler/setup' patches things such that Bundler will restricts where code can be required from to just what's in your Gemfile. If you've got a Gemfile, that's exactly what you want. But if you don't--say you're just running the shoes executable on a file somewhere--this blocks you from actually loading the rest of shoes!

Not to self-promote too much, but actually have a lightning talk on how this works at pdx.rb a while back. Hopefully explains in a little more detail how that happens 🎥

@jasonrclark jasonrclark deleted the revert-1189-jclark/require-bundler branch December 14, 2015 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants