Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop doing Initalization as module #1387

Merged
merged 1 commit into from Feb 11, 2017
Merged

Conversation

jasonrclark
Copy link
Member

Now that we have a base class, just use it more directly.

Less magic 馃寛 more better 馃憣

Now that we have a base class, just use it more directly.
Copy link
Member

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but what is easier/less magic about this? I don't quite get it, it's just the methods moved from the module to the base class, might make the lookup chain more consistent but otherwise I don't see it. Not a critique, I'd just like to understand it :)

@jasonrclark
Copy link
Member Author

Probably overstated calling it "magic". For me it's a little exotic though for a class to get its initialize method from a module (although the mechanism is just good old module included methods) and definitely unneeded indirection now.

@PragTob
Copy link
Member

PragTob commented Feb 11, 2017

That is definitely true :)

@PragTob PragTob merged commit 8033b11 into master Feb 11, 2017
@PragTob PragTob deleted the drop-initialization-module branch February 11, 2017 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants