Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes the team.jpg image and uses code instead! #71

Merged
merged 6 commits into from
Nov 27, 2014
Merged

removes the team.jpg image and uses code instead! #71

merged 6 commits into from
Nov 27, 2014

Conversation

eliduke
Copy link
Contributor

@eliduke eliduke commented Nov 26, 2014

This seemed like a easy intro into helping out with shoes. I hope you like what I did!

@PragTob
Copy link
Member

PragTob commented Nov 27, 2014

OH MY GOD I WANTED TO HAVE THIS FOR SUCH A LONG TIME THANK YOU VERY MUCH YES I KNOW I'M ON CAPSLOCK I'M JUST SUPPER EXCITED =D 👍 🎆

I'll leave this tab open until I got some other urgent work done will review :)

@jasonrclark
Copy link
Member

Agreed! Ran this locally and looks great to me. 💖 And now maybe I can get on the team member list! 😁

On that note, here's a few folks that have been active lately, and should get on the list:

So. Much. Awesome:exclamation::exclamation::exclamation:

@PragTob
Copy link
Member

PragTob commented Nov 27, 2014

Filed a PR for your PR, because well that's still a bit hard some times. I could also merge it instantly.

Couple of things: @ccoupe @KCErb @jasonrclark should definitely be added, if they don't object.

Similarly there are a couple of folks I haven't heard from in a long, long time... I think when we made the website it was like everyone with a commit gets to be on the page.

So, I don't want to hurt any feelings here or something like that (and I don't think I do) but I'd remove a couple of folks that made a couple of commits when the project started but then moved on afterwards (which is totally fine). That'd be alindemann, ychatz and nashby.

Peter and James are still around (upon request), and well peter layed out all the foundations we are working on these days :)

What do you think?

Cheers,
Tobi

@jasonrclark
Copy link
Member

Seems reasonable here. Could also link the contribution page on the repos for the full list of everyone who has helped.

@PragTob
Copy link
Member

PragTob commented Nov 27, 2014

Yeah, I'd love links to shoes/{shoesrb.com, shoes, shoes4} - great idea! We could also have a page/section that just pulls in everyone from all shoes org repos, aggregates their stats and then sorts them by random/commit/whatever... ot just name. Or whatever.

That's be sweet, but nothing necessary - maybe something for a hack day/hack evening :)

@jasonrclark
Copy link
Member

Agreed, totally a task for another day, but would be rad to generate off the GitHub API someday.

For now happy to :shipit: with @PragTob's fix and maybe adding those other names. ❤️

@eliduke
Copy link
Contributor Author

eliduke commented Nov 27, 2014

Sounds great, y'all. I removed older team members and added new ones.

@PragTob
Copy link
Member

PragTob commented Nov 27, 2014

Seems great, thanks a bunch for your work! =)

PragTob added a commit that referenced this pull request Nov 27, 2014
removes the team.jpg image and uses code instead!
@PragTob PragTob merged commit 9c67096 into shoes:gh-pages Nov 27, 2014
@wpp
Copy link
Contributor

wpp commented Nov 28, 2014

I think this closes #7 as well. Thanks @eliduke

@PragTob
Copy link
Member

PragTob commented Nov 28, 2014

Yeah I'll close it thanks for the hint Philipp! Will oprn a new one, though for automated retrieval/showcase.

@JesseHerrick
Copy link
Contributor

I posted a solution over at #72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants