-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removes the team.jpg image and uses code instead! #71
Conversation
…link to their github page
OH MY GOD I WANTED TO HAVE THIS FOR SUCH A LONG TIME THANK YOU VERY MUCH YES I KNOW I'M ON CAPSLOCK I'M JUST SUPPER EXCITED =D 👍 🎆 I'll leave this tab open until I got some other urgent work done will review :) |
Agreed! Ran this locally and looks great to me. 💖 And now maybe I can get on the team member list! 😁 On that note, here's a few folks that have been active lately, and should get on the list: So. Much. Awesome:exclamation::exclamation::exclamation: |
* also fixed a little oopsie with a <, but psshhhh
Filed a PR for your PR, because well that's still a bit hard some times. I could also merge it instantly. Couple of things: @ccoupe @KCErb @jasonrclark should definitely be added, if they don't object. Similarly there are a couple of folks I haven't heard from in a long, long time... I think when we made the website it was like everyone with a commit gets to be on the page. So, I don't want to hurt any feelings here or something like that (and I don't think I do) but I'd remove a couple of folks that made a couple of commits when the project started but then moved on afterwards (which is totally fine). That'd be alindemann, ychatz and nashby. Peter and James are still around (upon request), and well peter layed out all the foundations we are working on these days :) What do you think? Cheers, |
Seems reasonable here. Could also link the contribution page on the repos for the full list of everyone who has helped. |
Yeah, I'd love links to shoes/{shoesrb.com, shoes, shoes4} - great idea! We could also have a page/section that just pulls in everyone from all shoes org repos, aggregates their stats and then sorts them by random/commit/whatever... ot just name. Or whatever. That's be sweet, but nothing necessary - maybe something for a hack day/hack evening :) |
Agreed, totally a task for another day, but would be rad to generate off the GitHub API someday. For now happy to with @PragTob's fix and maybe adding those other names. ❤️ |
Sounds great, y'all. I removed older team members and added new ones. |
Seems great, thanks a bunch for your work! =) |
removes the team.jpg image and uses code instead!
Yeah I'll close it thanks for the hint Philipp! Will oprn a new one, though for automated retrieval/showcase. |
I posted a solution over at #72. |
This seemed like a easy intro into helping out with shoes. I hope you like what I did!