-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop support of Perl 5.12 #151
Conversation
WalkthroughThe recent modifications streamline the project's Perl dependencies by advancing the minimum required Perl version to 5.014. This update is reflected in both the project's Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/test.yml (1 hunks)
- cpanfile (1 hunks)
Additional comments: 2
cpanfile (1)
- 1-1: The update of the required Perl version from '5.012000' to '5.014000' in the
cpanfile
is aligned with the PR's objective to drop support for Perl 5.12. This change is straightforward and should not introduce issues, assuming that the project does not rely on any deprecated features removed in Perl 5.14. However, it's important to ensure that all project dependencies are compatible with Perl 5.14..github/workflows/test.yml (1)
- 65-70: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
Removing Perl 5.12 from the automated testing workflow aligns with the PR's objective to drop support for Perl 5.12, as reflected in the
cpanfile
. This change ensures that automated tests will focus on supported Perl versions, which is beneficial for maintaining the project's testing efficiency and relevance. It's recommended to review the remaining Perl versions in the testing matrix to ensure they are all still relevant and supported by the project.
Summary by CodeRabbit