introduce M1 Mac #1018
introduce M1 Mac #1018
Conversation
|
Warning Rate Limit Exceeded@shogo82148 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 5 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update involves expanding the testing environment by adding macOS 14 to the array of operating systems used for checks. This enhancement aims to ensure the software's compatibility and performance across an even broader range of environments, reflecting a commitment to supporting the latest technology platforms. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -36,6 +36,7 @@ jobs: | |||
| os: | |||
| - ubuntu-22.04 | |||
| - ubuntu-20.04 | |||
| - macos-14 | |||
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
label "macos-14" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/test.yml (1 hunks)
Additional comments: 1
.github/workflows/test.yml (1)
- 39-39: The addition of
macos-14to the testing matrix is a positive step towards ensuring compatibility with the M1 Mac architecture. This change aligns with the PR's objectives and should help in identifying any platform-specific issues early in the development cycle.
| @@ -83,6 +83,31 @@ jobs: | |||
| env: | |||
| GITHUB_TOKEN: ${{ github.token }} | |||
|
|
|||
| build-darwin-arm64: | |||
| runs-on: macos-14 | |||
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
label "macos-14" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
| @@ -80,6 +80,28 @@ jobs: | |||
| MARIADB_VERSION: ${{ matrix.mariadb }} | |||
| GITHUB_TOKEN: ${{ github.token }} | |||
|
|
|||
| build-darwin-arm64: | |||
| runs-on: macos-14 | |||
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
label "macos-14" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
|
building MySQL fails with the following error: |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .github/build-mysql-darwin-macos14.sh (1 hunks)
- .github/workflows/build-mariadb.yml (2 hunks)
- .github/workflows/build-mysql.yml (2 hunks)
Additional comments: 3
.github/build-mysql-darwin-macos14.sh (3)
- 12-23: The architecture detection logic is clear and straightforward. However, it's essential to ensure that the script is only intended to run on architectures that are explicitly supported (
x86_64andarm64).- 37-95: The conditional logic for building OpenSSL based on the MySQL version is well-implemented. However, ensure that the OpenSSL versions specified (
OPENSSL_VERSION1_1_1andOPENSSL_VERSION3) are compatible with the MySQL versions being built.Consider verifying the compatibility of OpenSSL versions with the MySQL versions to ensure there are no runtime issues due to OpenSSL version mismatches.
- 98-163: The steps for downloading, extracting, patching, and building MySQL are well-structured. However, it's crucial to ensure that the patches applied (
$ROOT/../patches/mysql/$MYSQL_VERSIONand$ROOT/../patches/mysql/$MYSQL_VERSION/darwin) exist and are relevant to the MySQL version being built.Verify the existence and relevance of the patches for the specific MySQL versions to ensure they apply correctly and do not introduce issues.
| @@ -80,6 +80,28 @@ jobs: | |||
| MARIADB_VERSION: ${{ matrix.mariadb }} | |||
| GITHUB_TOKEN: ${{ github.token }} | |||
|
|
|||
| build-darwin-arm64: | |||
| runs-on: macos-14 | |||
There was a problem hiding this comment.
The runs-on value macos-14 is specified for the build-darwin-arm64 job. However, according to the existing comments from the actionlint bot, macos-14 is not a recognized label. This could potentially cause the workflow to fail at runtime.
- runs-on: macos-14
+ runs-on: macos-latest # Adjust to the correct version if macos-14 is not yet supportedCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| runs-on: macos-14 | |
| runs-on: macos-latest # Adjust to the correct version if macos-14 is not yet supported |
There was a problem hiding this comment.
macos-14 is valid.
actionlint is issuing warnings based on the outdated label list.
https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/
There was a problem hiding this comment.
@shogo82148, thank you for the clarification and for providing the link to the GitHub blog post. I understand now that macos-14 is indeed a valid label for GitHub Actions runners. I appreciate your patience and the additional information.
| @@ -83,6 +83,31 @@ jobs: | |||
| env: | |||
| GITHUB_TOKEN: ${{ github.token }} | |||
|
|
|||
| build-darwin-arm64: | |||
| runs-on: macos-14 | |||
There was a problem hiding this comment.
Similar to the previous file, the runs-on value macos-14 is specified for the build-darwin-arm64 job in .github/workflows/build-mysql.yml. Given the actionlint bot's feedback, macos-14 is not recognized, which could lead to workflow execution issues.
- runs-on: macos-14
+ runs-on: macos-latest # Update this to the correct macOS version if macos-14 is unsupportedCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| runs-on: macos-14 | |
| runs-on: macos-latest # Update this to the correct macOS version if macos-14 is unsupported |
|
|
||
| set -e | ||
|
|
||
| MYSQL_VERSION=$1 |
There was a problem hiding this comment.
Ensure that the script validates the provided MySQL version format to prevent potential issues with unexpected or malformed input.
Consider adding a regex check for the MySQL version format to ensure it's valid before proceeding with the build process.
Summary by CodeRabbit