MySQL 8.4.0 is released

[shogo82148]

Summary by CodeRabbit

• New Features
  • Added support for MySQL version 8.4.0.
• Documentation
  • Updated README to include support for MySQL version 8.4.

[coderabbitai]

Walkthrough

This update primarily introduces support for MySQL version 8.4.0, involving modifications to build configurations and patch management. The changes streamline the building process and adjust the handling of specific files during installation, particularly for Windows environments. These adjustments are crucial for accommodating the new version in both development workflows and automated testing.

Changes

File Path	Summary
.../skip-install-pdb.patch	Skips installing .pdb files for Windows targets due to size constraints in GitHub Actions.
.../build-cno_huffman_generator.patch, .../windows/fix-building-libcno.patch	Modifies CMakeLists.txt to adjust build settings for libcno, focusing on the inclusion and installation of the cno_huffman_generator executable.
versions/mysql.json, README.md, .github/workflows/test.yml	Adds support for MySQL version 8.4.0 across documentation and testing workflows.

🐰✨
In the warren of code, a new patch hops in,
With tweaks and with changes, a new phase to begin.
Version 8.4, now joins the fray,
Under moonlit skies, we code and we play.
Let our tests pass, through night and through day!

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Consider the implications of removing EXCLUDE_FROM_ALL.

Removing EXCLUDE_FROM_ALL from MYSQL_ADD_EXECUTABLE makes cno_huffman_generator part of the default build targets. This change could potentially increase build times or include unnecessary targets in some builds. It's important to verify whether this target is essential for all default builds or if it should be optional.

[coderabbitai]

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 964bd5e and 4241717.

Files selected for processing (1)

• patches/mysql/8.4.0/windows/fix-building-libcno.patch (1 hunks)

Additional comments not posted (1)

patches/mysql/8.4.0/windows/fix-building-libcno.patch (1)

10-10: Removal of EXCLUDE_FROM_ALL directive.

The removal of the EXCLUDE_FROM_ALL directive aligns with the PR objectives to streamline the build process for MySQL 8.4.0. This change should help in making the cno_huffman_generator part of the default build targets, which is intended per the PR summary.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4241717 and f4ab0dd.

Files selected for processing (1)

• versions/mysql.json (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• versions/mysql.json

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f4ab0dd and 20b02ae.

Files selected for processing (1)

• .github/workflows/test.yml (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• .github/workflows/test.yml