Ubuntu24.04 is released #1060
Ubuntu24.04 is released #1060
Conversation
WalkthroughThe recent updates primarily focus on enhancing compatibility and support for newer operating systems and compilers in the build and test workflows for MySQL and MariaDB. This includes adding Ubuntu 24.04 to the matrix configuration and addressing compilation issues with GCC 13. Additionally, specific patches have been applied to resolve build errors related to GCC 13 in both MySQL and MariaDB. Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -34,6 +34,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: | |||
| - ubuntu-24.04 | |||
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
label "ubuntu-24.04" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/build-mariadb.yml (1 hunks)
- .github/workflows/build-mysql.yml (1 hunks)
- .github/workflows/test.yml (1 hunks)
Files skipped from review due to trivial changes (3)
- .github/workflows/build-mariadb.yml
- .github/workflows/build-mysql.yml
- .github/workflows/test.yml
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mysql-linux.sh (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/build-mysql-linux.sh
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- patches/mysql/8.1.0/fix-gcc13-error.patch (1 hunks)
Additional comments not posted (2)
patches/mysql/8.1.0/fix-gcc13-error.patch (2)
7-7: Change in compiler flags to suppress warnings.Ensure this change does not inadvertently hide other important warnings.
20-26: Conditional compilation option added for GCC versions greater than 13.Verify that this condition correctly identifies GCC version 13 and above in all environments where this code will be compiled.
This reverts commit 2a945cf.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- patches/mysql/8.1.0/fix-broken-build-without-test.patch (1 hunks)
Additional comments not posted (1)
patches/mysql/8.1.0/fix-broken-build-without-test.patch (1)
22-29: The conditional inclusion of compiler options based on the presence of unit tests is a good practice to avoid unintended side effects during different build configurations.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mysql-linux.sh (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/build-mysql-linux.sh
There was a problem hiding this comment.
Actionable comments posted: 3
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/build-mariadb-linux.sh (2 hunks)
- .github/build-mysql-linux.sh (3 hunks)
- patches/mariadb/10.2.44/rocksdb-does-not-compile-with-gcc13.patch (1 hunks)
- patches/mariadb/10.3.39/rocksdb-does-not-compile-with-gcc13.patch (1 hunks)
- patches/mariadb/10.7.8/rocksdb-does-not-compile-with-gcc13.patch (1 hunks)
Files skipped from review due to trivial changes (1)
- patches/mariadb/10.2.44/rocksdb-does-not-compile-with-gcc13.patch
Files skipped from review as they are similar to previous changes (1)
- .github/build-mysql-linux.sh
Additional comments not posted (1)
.github/build-mariadb-linux.sh (1)
28-37: Dynamic selection of compiler versions is a robust enhancement.The script's logic to dynamically select the most recent available version of GCC and G++ ensures that the latest compiler features and optimizations are utilized. This is a significant improvement in ensuring the build environment is up-to-date.
Also applies to: 48-57
| +ADD_DEFINITIONS(-Duint64_t=u_int64_t) | ||
| +ADD_DEFINITIONS(-Duint32_t=u_int32_t) | ||
| +ADD_DEFINITIONS(-Duint16_t=u_int16_t) | ||
| +ADD_DEFINITIONS(-Duint8_t=u_int8_t) |
There was a problem hiding this comment.
Consider using standard integer types for better portability.
While the current changes address the compilation issue, using standard integer types (<cstdint>) would enhance the portability and maintainability of the code. If possible, consider updating the submodule or applying a patch that includes the necessary headers.
| +ADD_DEFINITIONS(-Duint64_t=u_int64_t) | ||
| +ADD_DEFINITIONS(-Duint32_t=u_int32_t) | ||
| +ADD_DEFINITIONS(-Duint16_t=u_int16_t) | ||
| +ADD_DEFINITIONS(-Duint8_t=u_int8_t) |
There was a problem hiding this comment.
Consider using standard integer types for better portability.
As with the previous patch, using standard integer types (<cstdint>) would enhance the portability and maintainability of the code. If possible, consider updating the submodule or applying a patch that includes the necessary headers.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mariadb-linux.sh (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/build-mariadb-linux.sh
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/build-mysql-linux.sh (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/build-mysql-linux.sh
https://github.blog/changelog/2024-05-14-github-hosted-runners-public-beta-of-ubuntu-24-04-is-now-available/
Summary by CodeRabbit
New Features
Bug Fixes
Chores