remove tests from MariaDB builds #1064
Conversation
WalkthroughThe updates across the build scripts for macOS, Linux, and Windows involve the removal of the Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/build-mariadb-darwin.sh (1 hunks)
- .github/build-mariadb-linux.sh (1 hunks)
- .github/build-mariadb-windows.ps1 (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/build-mariadb-darwin.sh
- .github/build-mariadb-linux.sh
Additional comments not posted (1)
.github/build-mariadb-windows.ps1 (1)
163-165: Conditional check and removal ofmariadb-testdirectory implemented as expected.This change aligns with the PR's objective to remove tests from MariaDB builds. Ensure that this directory is not required elsewhere in the build process or by any other scripts.
Verification successful
The search for references to
mariadb-testin the repository did not produce any output, indicating that the directory is not referenced elsewhere in the codebase.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `mariadb-test` directory is not required elsewhere in the build process. # Test: Search for any other references to `mariadb-test` in the repository. rg --type ps1 --type sh 'mariadb-test'Length of output: 66
Script:
#!/bin/bash # Description: Verify that the `mariadb-test` directory is not required elsewhere in the build process. # Test: Search for any other references to `mariadb-test` in the repository. rg --type powershell --type sh 'mariadb-test'Length of output: 80
Script:
#!/bin/bash # Description: Verify that the `mariadb-test` directory is not required elsewhere in the build process. # Test: Search for any other references to `mariadb-test` in the repository. rg --type ps1 --type sh 'mariadb-test'Length of output: 66
Script:
#!/bin/bash # Description: Verify that the `mariadb-test` directory is not required elsewhere in the build process. # Test: Search for any other references to `mariadb-test` in the repository. rg 'mariadb-test'Length of output: 17
|
before: |
|
After: |
Summary by CodeRabbit
mariadb-testdirectory during MariaDB build on all platforms (Darwin, Linux, Windows).