enable WITH_AUTHENTICATION_CLIENT_PLUGINS on macos-14

[shogo82148]

Summary by CodeRabbit

• Chores
  • Updated the build script for MySQL on macOS to handle different MySQL versions more effectively.

[coderabbitai]

Walkthrough

The changes in the .github/build-mysql-darwin-macos14.sh script adapt cmake commands to accommodate different MySQL versions. The script now specifies options for MySQL 9.0 or later, version 8.0, and other versions. These adjustments ensure compatibility and optimal configuration across MySQL versions by altering plugin, SSL, and unit test settings.

Changes

File	Change Summary
.github/build-mysql-darwin-macos14.sh	Modified cmake commands based on MySQL version: - Added -DWITH_AUTHENTICATION_CLIENT_PLUGINS=1 for MySQL 9.0 or later. - Removed RocksDB and Boost options for MySQL 9.0 or later. - Set WITH_UNIT_TESTS=0 for all versions. - Adjusted SSL and installation prefix settings based on version.

Poem

In the land of code where scripts reside,
MySQL versions now take a ride.
With plugins, tests, and SSL in line,
Each version’s needs we now define.
A build so smooth, oh what a feat,
Our script's evolved, efficient and neat!

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[shogo82148]

ref. #1089 (comment)

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5833afc and ab85cd8.

Files selected for processing (1)

• .github/build-mysql-darwin-macos14.sh (1 hunks)

Additional comments not posted (3)

.github/build-mysql-darwin-macos14.sh (3)

138-144: Verify MySQL 8.0 configuration.

The cmake command for MySQL 8.0 includes setting -DWITH_UNIT_TESTS=0, adding Boost options, and adjusting SSL settings. These changes appear correct and align with the PR objectives.

However, ensure these options are correctly supported in the targeted MySQL versions.

---

131-137: Verify MySQL 9.0 or later configuration.

The cmake command for MySQL 9.0 or later includes setting -DWITH_AUTHENTICATION_CLIENT_PLUGINS=1, removing RocksDB and Boost options, and setting -DWITH_UNIT_TESTS=0. These changes appear correct and align with the PR objectives.

However, ensure these options are correctly supported in the targeted MySQL versions.

---

145-152: Verify configuration for other MySQL versions.

The cmake command for other MySQL versions includes setting -DWITH_UNIT_TESTS=0, adding Boost and RocksDB options, and adjusting SSL settings. These changes appear correct and align with the PR objectives.

However, ensure these options are correctly supported in the targeted MySQL versions.