Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unintended shadowing assignment #60

Merged
merged 1 commit into from Jan 8, 2021

Conversation

Songmu
Copy link
Contributor

@Songmu Songmu commented Jan 7, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #60 (0e4880b) into main (cf38712) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files          11       11           
  Lines         938      938           
=======================================
  Hits          695      695           
  Misses        174      174           
  Partials       69       69           
Impacted Files Coverage Δ
conn.go 69.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf38712...0e4880b. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.571% when pulling 0e4880b on Songmu:fix-stmt-assignment into cf38712 on shogo82148:main.

Copy link
Owner

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148 shogo82148 merged commit de14c4e into shogo82148:main Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants