Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Integration testing data #127

Closed
wants to merge 3 commits into from
Closed

Add Integration testing data #127

wants to merge 3 commits into from

Conversation

abhinavrai44
Copy link
Contributor

No description provided.

@abhinavrai44 abhinavrai44 changed the title Integration testing data for nystrom and random forest regression Integration testing data for nystrom and random forest regression #3580 Dec 27, 2016
@karlnapf
Copy link
Member

All good but please make a proper commit message
"Integration testing data for nystrom and random forest regression"

You can use git commit -amend to change the existing one

@abhinavrai44 abhinavrai44 changed the title Integration testing data for nystrom and random forest regression #3580 Integration testing data for nystrom and random forest regression Dec 29, 2016
@abhinavrai44 abhinavrai44 changed the title Integration testing data for nystrom and random forest regression Integration testing data Dec 29, 2016
@abhinavrai44 abhinavrai44 changed the title Integration testing data Add Integration testing data Dec 29, 2016
@abhinavrai44
Copy link
Contributor Author

Sorry,
I am just beginning to contribute to open-source. Is this ok ?

@karlnapf
Copy link
Member

karlnapf commented Jan 9, 2017

This is almost good. Squash all the commits into a single one so there is just one commit (and one commit message) Then ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abhinavrai44 @karlnapf