add test for string parameters

shogun-toolbox · Jul 20, 2018 · 0230201 · 0230201
1 parent f8963c1
commit 0230201
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/tests/unit/base/MockObject.h b/tests/unit/base/MockObject.h
@@ -83,6 +83,9 @@ namespace shogun
 			watch_param("object", &m_object);
 			m_parameters->add(
 			    (CSGObject**)&m_object, "object", "The object (tm)");
+
+			m_string = "Shogun rocks!";
+			watch_param("string", &m_string);
 		}
 
 		void free_single()
@@ -246,6 +249,8 @@ namespace shogun
 		T* m_raw_matrix_basic;
 		index_t m_raw_matrix_basic_rows;
 		index_t m_raw_matrix_basic_cols;
+
+		std::string m_string;
 	};
 
 	/** @brief Used to test the tags-parameter framework

diff --git a/tests/unit/base/SGObject_unittest.cc b/tests/unit/base/SGObject_unittest.cc
@@ -78,6 +78,16 @@ TYPED_TEST(SGObjectEquals, different_basic)
 	EXPECT_FALSE(obj2->equals(obj1));
 }
 
+TYPED_TEST(SGObjectEquals, different_string)
+{
+	auto obj1 = some<CCloneEqualsMock<TypeParam>>();
+	auto obj2 = some<CCloneEqualsMock<TypeParam>>();
+
+	obj1->m_string = "Oh no!";
+	EXPECT_FALSE(obj1->equals(obj2));
+	EXPECT_FALSE(obj2->equals(obj1));
+}
+
 TYPED_TEST(SGObjectEquals, different_object)
 {
 	auto obj1 = some<CCloneEqualsMock<TypeParam>>();
@@ -221,6 +231,7 @@ TYPED_TEST(SGObjectClone, equals_non_empty)
 {
 	auto obj = some<CCloneEqualsMock<TypeParam>>();
 	obj->m_basic -= 1;
+	obj->m_string = "Non empty string";
 	obj->m_object->m_some_value -= 1;
 	obj->m_sg_vector[0] -= 1;
 	obj->m_sg_matrix(0, 0) = 0;