Fixing memory leak in NCBM solver.

shogun-toolbox · Mar 16, 2014 · 18577fd · 18577fd
1 parent 4e1874a
commit 18577fd
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/src/shogun/structure/libncbm.cpp b/src/shogun/structure/libncbm.cpp
@@ -321,7 +321,9 @@ BmrmStatistics svm_ncbm_solver(
 {
 	BmrmStatistics ncbm;
 	libqp_state_T qp_exitflag={0, 0, 0, 0};
-	int32_t w_dim = machine->get_model()->get_dim();
+
+	CStructuredModel* model = machine->get_model();
+	int32_t w_dim = model->get_dim();
 
 	maxCPs = _BufSize;
 	BufSize = _BufSize;
@@ -756,6 +758,17 @@ BmrmStatistics svm_ncbm_solver(
 	LIBBMRM_FREE(icp_stats.ACPs);
 	LIBBMRM_FREE(icp_stats.H_buff);
 
+        cp_ptr=CPList_head;
+        while(cp_ptr!=NULL)
+        {
+                bmrm_ll * cp_ptr_this=cp_ptr;
+                cp_ptr=cp_ptr->next;
+                LIBBMRM_FREE(cp_ptr_this);
+                cp_ptr_this=NULL;
+        }
+
+	SG_UNREF(model);
+
 	return ncbm;
 }