Skip to content

Commit

Permalink
too many overrides
Browse files Browse the repository at this point in the history
mea culpa
  • Loading branch information
vigsterkr committed Jul 26, 2018
1 parent 32c895a commit 55fa635
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions src/shogun/labels/DenseLabels.h
Expand Up @@ -74,15 +74,15 @@ namespace shogun
*
* @param loader File object via which to load data
*/
virtual void load(CFile* loader) override;
virtual void load(CFile* loader);

/** save labels to file
*
* not possible with subset
*
* @param writer File object via which to save data
*/
virtual void save(CFile* writer) override;
virtual void save(CFile* writer);

/** set label
*
Expand Down Expand Up @@ -263,7 +263,7 @@ namespace shogun
*/
int32_t get_num_labels() const override;

virtual const char* get_name() const = 0;
virtual const char* get_name() const override = 0;

public:
/** label designates classify reject */
Expand Down
4 changes: 2 additions & 2 deletions src/shogun/labels/MultilabelLabels.h
Expand Up @@ -78,7 +78,7 @@ class CMultilabelLabels : public CLabels
*
* @param context optional message to convey the context
*/
void ensure_valid(const char * context = NULL);
void ensure_valid(const char * context = NULL) override;

/** get label type
*
Expand All @@ -105,7 +105,7 @@ class CMultilabelLabels : public CLabels
*
* @return number of classes
*/
virtual int32_t get_num_classes() const override;
virtual int32_t get_num_classes() const;

/** set labels
*
Expand Down
6 changes: 3 additions & 3 deletions src/shogun/labels/StructuredLabels.h
Expand Up @@ -57,7 +57,7 @@ class CStructuredLabels : public CLabels
*
* @param label label to add
*/
virtual void add_label(CStructuredData* label) override;
virtual void add_label(CStructuredData* label);

/** get labels
*
Expand All @@ -73,7 +73,7 @@ class CStructuredLabels : public CLabels
*
* @return label object
*/
virtual CStructuredData* get_label(int32_t idx) override;
virtual CStructuredData* get_label(int32_t idx);

/**
* set label, possible with subset. This method should be used
Expand All @@ -85,7 +85,7 @@ class CStructuredLabels : public CLabels
*
* @return if setting was successful
*/
virtual bool set_label(int32_t idx, CStructuredData* label) override;
virtual bool set_label(int32_t idx, CStructuredData* label);

/** get number of labels, depending on wheter a subset is set
*
Expand Down
4 changes: 2 additions & 2 deletions src/shogun/regression/KRRNystrom.h
Expand Up @@ -102,14 +102,14 @@ less than number of data points (%d)\n", m_num_rkhs_basis, n);
bool train_machine(CFeatures *data) override;

/** @return object name */
virtual const char* get_name() const { return "KRRNystrom"; }
virtual const char* get_name() const override { return "KRRNystrom"; }

protected:
/** Train regression using the Nyström method.
*
* @return boolean to indicate success
*/
virtual bool solve_krr_system();
virtual bool solve_krr_system() override;

/** Sample indices to pick rows/columns from kernel matrix
*
Expand Down

0 comments on commit 55fa635

Please sign in to comment.