Skip to content

Commit

Permalink
Fix -Wno-c++11-narrowing flag and disable c++11 on Darwin with
Browse files Browse the repository at this point in the history
PythonModular
Travis: install jinja2 on osx job
  • Loading branch information
vigsterkr committed Aug 7, 2013
1 parent 7f0dfcf commit 7b14039
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 16 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Expand Up @@ -53,6 +53,7 @@ virtualenv:
before_install:
- if [ -z $OSX ] ; then sudo apt-get update -qq ; else brew update ; fi
- if [ -z $OSX ] ; then sudo apt-get install -qq libbz2-dev cdbs libarpack2-dev libatlas-base-dev libblas-dev libglpk-dev libhdf5-serial-dev zlib1g-dev libxml2-dev libreadline6-dev libreadline-dev libsnappy-dev liblzo2-dev liblzma-dev liblapack-dev gdb cmake python-jinja2 $EXTRA_PACKAGES ; else brew install cmake ; fi
- if [ $OSX ] ; then curl -O https://raw.github.com/rudix-mac/package-manager/master/rudix.py && sudo python rudix.py install rudix && sudo rudix install jinja2 ; fi
- $CUSTOM_PKG
before_script:
- mkdir build
Expand Down
35 changes: 20 additions & 15 deletions CMakeLists.txt
Expand Up @@ -65,22 +65,28 @@ IF(CMAKE_COMPILER_IS_GNUCXX)
ENDIF()

# check for supported c++11 features
INCLUDE(CheckCXX11Features)

IF(_HAS_CXX11_FLAG)
LIST(APPEND DEFINES HAVE_CXX11)
SET(HAVE_CXX11 1)
SET(CMAKE_CXX_FLAGS "${CXX11_COMPILER_FLAGS} ${CMAKE_CXX_FLAGS}")
ENDIF()
#
# clang with -std=c++11 and -stdlib=libc++ does not work
# well with swig generated cxx for python
# hence disable c++11 for this case.
IF (NOT (DARWIN AND PythonModular))
INCLUDE(CheckCXX11Features)

IF(_HAS_CXX11_FLAG)
LIST(APPEND DEFINES HAVE_CXX11)
SET(HAVE_CXX11 1)
SET(CMAKE_CXX_FLAGS "${CXX11_COMPILER_FLAGS} ${CMAKE_CXX_FLAGS}")
ENDIF()

IF(_HAS_CXX0X_FLAG)
LIST(APPEND DEFINES HAVE_CXX0X)
SET(HAVE_CXX0X 1)
SET(CMAKE_CXX_FLAGS "${CXX11_COMPILER_FLAGS} ${CMAKE_CXX_FLAGS}")
ENDIF()
IF(_HAS_CXX0X_FLAG)
LIST(APPEND DEFINES HAVE_CXX0X)
SET(HAVE_CXX0X 1)
SET(CMAKE_CXX_FLAGS "${CXX11_COMPILER_FLAGS} ${CMAKE_CXX_FLAGS}")
ENDIF()

IF (HAVE_CXX11_ATOMIC)
LIST(APPEND DEFINES HAVE_CXX11_ATOMIC)
IF (HAVE_CXX11_ATOMIC)
LIST(APPEND DEFINES HAVE_CXX11_ATOMIC)
ENDIF()
ENDIF()

# cpu tuning params
Expand Down Expand Up @@ -457,7 +463,6 @@ ENDIF()

# python modular
IF (PythonModular)
set(PythonLibs_FIND_VERSION ${PYTHON_VERSION_STRING})
FIND_PACKAGE(PythonLibs REQUIRED)
FIND_PACKAGE(NumPy REQUIRED)

Expand Down
2 changes: 1 addition & 1 deletion src/interfaces/python_modular/CMakeLists.txt
Expand Up @@ -4,7 +4,7 @@ include_directories(${PYTHON_INCLUDE_PATH} ${NUMPY_INCLUDE_DIRS})
#TODO: check for SWIG version where this bug has been applied already:
# https://github.com/swig/swig/pull/70

SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wnoc++11-narrowing")
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-c++11-narrowing")

GENERATE_MODULAR_TARGET(python ${CMAKE_CURRENT_SOURCE_DIR} ${PYTHON_LIBRARIES})

Expand Down

0 comments on commit 7b14039

Please sign in to comment.