Merge pull request #3654 from lkuchenb/fix/ModelSelectionParameters_s…

…et_values Fix CModelSelectionParameters::set_values()
shogun-toolbox · Feb 23, 2017 · 9546458 · 9546458
2 parents ce65285 + 251c7d4
commit 9546458
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/shogun/modelselection/ModelSelectionParameters.cpp b/src/shogun/modelselection/ModelSelectionParameters.cpp
@@ -92,17 +92,6 @@ void CModelSelectionParameters::append_child(CModelSelectionParameters* child)
 	m_child_nodes->append_element(child);
 }
 
-template <class T>
-void CModelSelectionParameters::set_values(const SGVector<T>& values,
-		EMSParamType value_type)
-{
-	/* possibly delete old range values */
-	delete_values();
-	m_values=values.vector;
-	m_values_length=values.vlen;
-	m_value_type=value_type;
-}
-
 void CModelSelectionParameters::build_values(float64_t min, float64_t max,
 		ERangeType type, float64_t step, float64_t type_base)
 {

diff --git a/src/shogun/modelselection/ModelSelectionParameters.h b/src/shogun/modelselection/ModelSelectionParameters.h
@@ -104,7 +104,14 @@ class CModelSelectionParameters: public CSGObject
 	 * @param value_type type of the provided vector
 	 */
 	template <class T>
-	void set_values(const SGVector<T>& values, EMSParamType value_type);
+	void set_values(const SGVector<T>& values, EMSParamType value_type)
+	{
+	    /* possibly delete old range values */
+	    delete_values();
+	    m_values=values.vector;
+	    m_values_length=values.vlen;
+	    m_value_type=value_type;
+	}
 
 	/** SG_PRINT's the tree of which this node is the base
 	 *