Skip to content

Commit

Permalink
fix undefined reference error for RefCount benchmark
Browse files Browse the repository at this point in the history
due wrong linking order RefCount benchmark failed to link
thnx for @LebedevRI to help figuring this out
the explanation for what has really happened is here:
https://stackoverflow.com/questions/45135/why-does-the-order-in-which-libraries-are-linked-sometimes-cause-errors-in-gcc
  • Loading branch information
vigsterkr committed Jul 20, 2018
1 parent cbaa656 commit a4dad48
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/shogun/CMakeLists.txt
Expand Up @@ -560,20 +560,22 @@ IF (BUILD_BENCHMARKS)
enable_testing()
add_library(shogun_benchmark_main ${CMAKE_CURRENT_SOURCE_DIR}/util/benchmark_main.cc)
if (APPLE)
target_link_libraries(shogun_benchmark_main benchmark)
target_link_libraries(shogun_benchmark_main benchmark shogun-static)
elseif(MSVC)
target_link_libraries(shogun_benchmark_main
benchmark
Shlwapi.lib
shogun-static
)
else()
target_link_libraries(shogun_benchmark_main
benchmark
pthread
shogun-static
)
endif()

set(SHOGUN_BENCHMARK_LINK_LIBS shogun-static shogun_benchmark_main)
set(SHOGUN_BENCHMARK_LINK_LIBS shogun_benchmark_main)

ADD_SHOGUN_BENCHMARK(features/RandomFourierDotFeatures_benchmark)
ADD_SHOGUN_BENCHMARK(features/hashed/HashedDocDotFeatures_benchmark)
Expand Down

0 comments on commit a4dad48

Please sign in to comment.