Unref input features in transformer::apply

shogun-toolbox · Jun 4, 2018 · d26eca7 · d26eca7
1 parent 788b1cc
commit d26eca7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/src/shogun/preprocessor/DensePreprocessor.cpp b/src/shogun/preprocessor/DensePreprocessor.cpp
@@ -97,6 +97,7 @@ CFeatures* CDensePreprocessor<ST>::apply(CFeatures* features, bool inplace)
 		matrix = matrix.clone();
 	auto feat_matrix = apply_to_matrix(matrix);
 	auto preprocessed = new CDenseFeatures<ST>(feat_matrix);
+	SG_UNREF(features);
 	SG_REF(preprocessed);
 	return preprocessed;
 }

diff --git a/src/shogun/preprocessor/SparsePreprocessor.h b/src/shogun/preprocessor/SparsePreprocessor.h
@@ -93,6 +93,7 @@ CFeatures* CSparsePreprocessor<ST>::apply(CFeatures* features, bool inplace)
 	apply_to_sparse_matrix(feature_matrix);
 
 	auto processed = new CSparseFeatures<ST>(feature_matrix);
+	SG_UNREF(features);
 	SG_REF(processed);
 
 	return processed;

diff --git a/src/shogun/preprocessor/StringPreprocessor.cpp b/src/shogun/preprocessor/StringPreprocessor.cpp
@@ -106,6 +106,7 @@ namespace shogun
 
 		auto processed = new CStringFeatures<ST>(
 		    string_list, string_features->get_alphabet());
+		SG_UNREF(features);
 		SG_REF(processed);
 
 		return processed;