fix the default arg value for factories and add f flag to ctags kinds

shogun-toolbox · Mar 26, 2018 · fc6bc81 · fc6bc81
1 parent 81bf114
commit fc6bc81
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/shogun/CMakeLists.txt b/src/shogun/CMakeLists.txt
@@ -458,7 +458,7 @@ IF (CTAGS_FOUND)
     ADD_CUSTOM_COMMAND(OUTPUT ${CTAGS_FILE}
         COMMAND ${CTAGS_EXECUTABLE} -f ${CTAGS_FILE}
         # classes, enums, functions
-        --c++-kinds=cgp
+        --c++-kinds=cfgp
         --fields=+im
         --exclude=*.cpp
         --languages=c++

diff --git a/src/shogun/util/factory.h b/src/shogun/util/factory.h
@@ -36,7 +36,7 @@ namespace shogun
 		return features;
 	}
 
-	CFeatures* features(CFile* file, EPrimitiveType primitive_type)
+	CFeatures* features(CFile* file, EPrimitiveType primitive_type = PT_FLOAT64)
 	{
 		REQUIRE(file, "No file provided.\n");
 		CFeatures* result = nullptr;
@@ -78,7 +78,7 @@ namespace shogun
 		return result;
 	}
 
-	CFile* csv_file(std::string fname, char rw)
+	CFile* csv_file(std::string fname, char rw = 'r')
 	{
 		CFile* result = new CCSVFile(fname.c_str(), rw);
 		SG_REF(result);