Skip to content

Commit

Permalink
Merge pull request #1128 from votjakovr/develop
Browse files Browse the repository at this point in the history
Removed unused fields from inference method classes
  • Loading branch information
karlnapf committed May 24, 2013
2 parents 571ea98 + fdac479 commit ffa6cd0
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 32 deletions.
10 changes: 0 additions & 10 deletions src/shogun/regression/gp/ExactInferenceMethod.h
Expand Up @@ -17,8 +17,6 @@
namespace shogun
{

class CInferenceMethod;

/** @brief The Gaussian Exact Form Inference Method
*
* This inference method computes the Gaussian Method
Expand All @@ -44,9 +42,7 @@ class CInferenceMethod;
*/
class CExactInferenceMethod: public CInferenceMethod
{

public:

/** Default Constructor */
CExactInferenceMethod();

Expand Down Expand Up @@ -96,7 +92,6 @@ class CExactInferenceMethod: public CInferenceMethod
*/
virtual SGVector<float64_t> get_alpha();


/** get Cholesky Decomposition Matrix
*
* @return Cholesky Decomposition of Matrix:
Expand Down Expand Up @@ -167,16 +162,11 @@ class CExactInferenceMethod: public CInferenceMethod
virtual void update_all();

private:

/** Check if members of object are valid
* for inference
*/
void check_members();

/** Kernel matrix with noise */
SGMatrix<float64_t> m_kern_with_noise;
};

}
#endif // HAVE_EIGEN3

Expand Down
8 changes: 0 additions & 8 deletions src/shogun/regression/gp/FITCInferenceMethod.h
Expand Up @@ -39,9 +39,7 @@ namespace shogun
*/
class CFITCInferenceMethod: public CInferenceMethod
{

public:

/** Default Constructor*/
CFITCInferenceMethod();

Expand Down Expand Up @@ -93,7 +91,6 @@ class CFITCInferenceMethod: public CInferenceMethod
*/
virtual SGVector<float64_t> get_alpha();


/** get Cholesky Decomposition Matrix
*
* @return Cholesky Decomposition of Matrix:
Expand Down Expand Up @@ -168,15 +165,11 @@ class CFITCInferenceMethod: public CInferenceMethod
void init();

private:

/** Check if members of object are valid
* for inference
*/
void check_members();

/*Kernel matrix with noise*/
SGMatrix<float64_t> m_kern_with_noise;

/*noise of the latent variables*/
float64_t m_ind_noise;

Expand Down Expand Up @@ -220,7 +213,6 @@ class CFITCInferenceMethod: public CInferenceMethod
*/
SGVector<float64_t> m_be;
};

}
#endif // HAVE_EIGEN3

Expand Down
11 changes: 2 additions & 9 deletions src/shogun/regression/gp/InferenceMethod.h
Expand Up @@ -31,9 +31,7 @@ namespace shogun
*/
class CInferenceMethod : public CDifferentiableFunction
{

public:

/** Default Constructor
*
*/
Expand Down Expand Up @@ -166,7 +164,7 @@ class CInferenceMethod : public CDifferentiableFunction
*
* @return likelihood
*/
CLikelihoodModel* get_model() {SG_REF(m_model); return m_model; }
CLikelihoodModel* get_model() { SG_REF(m_model); return m_model; }

/**set likelihood model
*
Expand Down Expand Up @@ -202,9 +200,7 @@ class CInferenceMethod : public CDifferentiableFunction
return m_latent_features;
}


protected:

/** Update alpha matrix */
virtual void update_alpha() {}

Expand All @@ -221,7 +217,6 @@ class CInferenceMethod : public CDifferentiableFunction
void init();

protected:

/**Covariance Function*/
CKernel* m_kernel;

Expand Down Expand Up @@ -276,9 +271,7 @@ class CInferenceMethod : public CDifferentiableFunction

/** Kernel matrix from latent features */
SGMatrix<float64_t> m_latent_matrix;

};

}
#endif /* HAVE_EIGEN3 */
#endif /* CInferenceMethod_H_ */
#endif /* CINFERENCEMETHOD_H_ */
5 changes: 0 additions & 5 deletions src/shogun/regression/gp/LaplacianInferenceMethod.h
Expand Up @@ -45,9 +45,7 @@ namespace shogun
*/
class CLaplacianInferenceMethod: public CInferenceMethod
{

public:

/** Default Constructor*/
CLaplacianInferenceMethod();

Expand Down Expand Up @@ -97,7 +95,6 @@ class CLaplacianInferenceMethod: public CInferenceMethod
*/
virtual SGVector<float64_t> get_alpha();


/** get Cholesky Decomposition Matrix
*
* @return Cholesky Decomposition of Matrix:
Expand Down Expand Up @@ -220,7 +217,6 @@ class CLaplacianInferenceMethod: public CInferenceMethod
void init();

private:

/** Check if members of object are valid
* for inference
*/
Expand Down Expand Up @@ -271,7 +267,6 @@ class CLaplacianInferenceMethod: public CInferenceMethod
/*log likelihood*/
float64_t lp;
};

}
#endif // HAVE_EIGEN3

Expand Down

0 comments on commit ffa6cd0

Please sign in to comment.