Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-test the serialisation framework #1160

Closed
karlnapf opened this issue Jun 6, 2013 · 3 comments
Closed

Unit-test the serialisation framework #1160

karlnapf opened this issue Jun 6, 2013 · 3 comments

Comments

@karlnapf
Copy link
Member

karlnapf commented Jun 6, 2013

Since we have some bugs in there, we have to start writing tests systematically to know which parts are working and which are not.

The first step is to write tests for TParameter's load and save method.
This needs to be done for all types, i.e. all combinations of our primitive types (int8-64, float, etc), structure types (none, sparse, string), and container types (scalar, vector, matrix)

If all of those work, we can start dealing with the migration bugs. Also, this will allow us to very precisely track errors in the serialisation.

@lambday
Copy link
Member

lambday commented Jun 7, 2013

tests for load and save methods of TParameter has been added to cover all primitive types for scalar. Tests for vector and matrix types of float and complex have also been added ( #1162 and #1163 )

@karlnapf
Copy link
Member Author

karlnapf commented Jun 8, 2013

Very nice work! The next step would be matrices and vectors. We probably will not need all types covered for this since the code calls the same methods as the ones for which you added the tests.what is important though is to test borderline cases where eg. one dimension is empty.

@lambday
Copy link
Member

lambday commented Jun 8, 2013

Heiko,

Thanks. I added a few tests for matrices and vectors for float64_t and
complex64_t. yes dimension-empty case is not there. I'll add soon.

On Sat, Jun 8, 2013 at 11:30 PM, Heiko Strathmann
notifications@github.comwrote:

Very nice work! The next step would be matrices and vectors. We probably
will not need all types covered for this since the code calls the same
methods as the ones for which you added the tests.what is important though
is to test borderline cases where eg. one dimension is empty.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1160#issuecomment-19152756
.

Regards,
Rahul
+918879426396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants