You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since we have some bugs in there, we have to start writing tests systematically to know which parts are working and which are not.
The first step is to write tests for TParameter's load and save method.
This needs to be done for all types, i.e. all combinations of our primitive types (int8-64, float, etc), structure types (none, sparse, string), and container types (scalar, vector, matrix)
If all of those work, we can start dealing with the migration bugs. Also, this will allow us to very precisely track errors in the serialisation.
The text was updated successfully, but these errors were encountered:
tests for load and save methods of TParameter has been added to cover all primitive types for scalar. Tests for vector and matrix types of float and complex have also been added ( #1162 and #1163 )
Very nice work! The next step would be matrices and vectors. We probably will not need all types covered for this since the code calls the same methods as the ones for which you added the tests.what is important though is to test borderline cases where eg. one dimension is empty.
Very nice work! The next step would be matrices and vectors. We probably
will not need all types covered for this since the code calls the same
methods as the ones for which you added the tests.what is important though
is to test borderline cases where eg. one dimension is empty.
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1160#issuecomment-19152756
.
Since we have some bugs in there, we have to start writing tests systematically to know which parts are working and which are not.
The first step is to write tests for TParameter's load and save method.
This needs to be done for all types, i.e. all combinations of our primitive types (int8-64, float, etc), structure types (none, sparse, string), and container types (scalar, vector, matrix)
If all of those work, we can start dealing with the migration bugs. Also, this will allow us to very precisely track errors in the serialisation.
The text was updated successfully, but these errors were encountered: