Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of FactorGraph unit tests are buggy #1298

Closed
iglesias opened this issue Jul 24, 2013 · 6 comments
Closed

A couple of FactorGraph unit tests are buggy #1298

iglesias opened this issue Jul 24, 2013 · 6 comments

Comments

@iglesias
Copy link
Collaborator

Valgrind detects quite a few errors for conditional jumps or moves depending on unitialised values in FactorGraph.evaluate_enery_param_data and FactorGraph.evaluate_enery_param_data_sparse, see output of
valgrind --leak-check=full ./shogun-unit-test --gtest_filter=FactorGraph.evaluate_energy_param_data_*

These tests are also leaking memory.

@hushell, let's try to fix this :)

@iglesias
Copy link
Collaborator Author

I have temporarily disabled these tests in #1311.

@hushell
Copy link
Contributor

hushell commented Jul 25, 2013

@iglesias I'll fix ASAP.

@vigsterkr
Copy link
Member

can we close this one?

@hushell
Copy link
Contributor

hushell commented Feb 4, 2014

Sure. I'll take a look later today.

On Tue, Feb 4, 2014 at 4:45 AM, Viktor Gal notifications@github.com wrote:

can we close this one?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1298#issuecomment-34055683
.

/**

  • ============HuShell============
    */

@hushell
Copy link
Contributor

hushell commented Feb 10, 2014

@iglesias I tried valgrind --leak-check=full ./shogun-unit-test --gtest_filter=FactorGraph.evaluate_energy_param_data_*

There is no problem on my laptop. Shall we close this?

@iglesias
Copy link
Collaborator Author

Sure, it looks fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants