JSON breaks on INFTY

[karlnapf]

Whenever a parameter is inf, -inf, json cannot open the file.

In particular, io/SerializableJsonFile.cpp line 104: sais that it cannot open the file, which means that json_object_from_file returns NULL.

This is the last error in serialization unit test branch

Assigning to @sonney2k since he wrote the thing

[karlnapf]

Oh, writing works btw. But reading the written object fails. The file contains "inf" strings

[karlnapf]

https://gist.github.com/karlnapf/6343428 contains code to reproduce and output of the file.
I changed the warning when json_object_from_file returns NULL to an error. Shogun fails due to uninitialized memory otherwise anyway

[vigsterkr]

come on there's like milion of 'standard' JSON serialization libraries out there.. why don't we just use that.
i already have an msgpack feature branch in my local git repo. imho we'd better off with that:

see, some examples:
http://avro.apache.org/
http://msgpack.org/

[karlnapf]

I agree

[sonney2k]

According to JSON spec, there is no Infinity or NaN values: http://json.org/

[sonney2k]

@karlnapf could you please email me a small file with serialized NaNs or inf in there for testing? I got the authors OK from the json-c project (also on github) that they will merge patches. And it seems easy to fix.

[karlnapf]

if you run the code in test/unit/io/SerializationJSON_unittest.cc.jinja2

with the disabled classes plugged into the placeholders:

#ifdef HAVE_JSON
{% set ignores = ['RationalApproximationIndividualJob',
'CCSOSVM',
'TwoStateModel'] %}

you will get such a file

[lisitsyn]

Would you agree we can't resolve this issue under current milestone Shogun 3.0?

It seems it would have some time to introduce fix and update dependencies.

[sonney2k]

true, moving to 3.1