Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a nice progress bar #3509

Closed
karlnapf opened this issue Nov 2, 2016 · 4 comments
Closed

Implement a nice progress bar #3509

karlnapf opened this issue Nov 2, 2016 · 4 comments

Comments

@karlnapf
Copy link
Member

karlnapf commented Nov 2, 2016

We currently have SG_PROGRESS in Shogun.

This task is to:

  • implement progress in all main outer loops
  • think about multi-core cases
  • implement with interactive modular langauges, e.g. https://github.com/tqdm/tqdm

First figure out how SG_PROGRESS works, try to use it, and then go from there....
All methods in the docs should have a progress...

@karlnapf karlnapf added this to the Shogun 6.0 milestone Nov 2, 2016
@geektoni
Copy link
Contributor

geektoni commented Mar 9, 2017

@karlnapf
About this one, would it be better a new implementation that will substitute SG_PROGRESS or an "upgrade" of SG_PROGRESS to make it also show a progress bar?

Btw, the current SGIO::progress implementation is faulty because in some cases it will display completely wrong timing information (I tried to use it with the cpp KNN meta example and the results were somewhat surprising ;) )

@karlnapf
Copy link
Member Author

karlnapf commented Mar 10, 2017

Steps:

  1. Use SG_PROGRESS in cases where it is not used, i.e. all outer loops where it makes sense. This is more a task of identifying methods that dont have any progress at all (x-validation, grid-search, gradient model selection, etc)
  2. Fix behaviour of SG_PROGRESS if wrong
  3. If there are design short-comings in SG_PROGRESS, discuss/suggest an improvement. Investigate how other libs do this, check if we can adapt ideas. Potentially refactor all of SG_PROGRESS uses in Shogun

All steps are independent but I think this is a good order of approaching them

Another cool thing would be to integrate SG_PROGRESS with ipython so that notebooks can show this

@karlnapf
Copy link
Member Author

LeastAngleRegression needs one

@vigsterkr
Copy link
Member

this is dooone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants