Fix wrong behaviour of SGIO::progress #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlnapf
approved these changes
Mar 14, 2017
src/shogun/io/SGIO.cpp
Outdated
| @@ -181,8 +181,18 @@ void SGIO::progress( | |||
| v=CMath::clamp(v,1e-5,100.0); | |||
| last_progress = v-1e-6; | |||
|
|
|||
| if ((v!=100.0) && (runtime - last_progress_time<0.5)) | |||
| if ((v!=100.0) && (runtime - last_progress_time<0.5)) { | |||
src/shogun/io/SGIO.cpp
Outdated
|
|
||
| // This is made to display correctly the percentage | ||
| // if the algorithm execution is too fast | ||
| if (current_val >= max_val-1){ |
|
Style fixed. |
|
Do we actually have a unit test for this thing? Just to ensure nothing crashes? |
|
As far as I know, the entire SGIO has no unit tests, which means no, there is no unit test to ensure the correctness of the code. Shall I spend some time creating one just to be sure it works as before? |
|
I think a test that at least executes the stuff you added would be good. Correctness is tricky as it just prints out. Not sure it is worth the hassle to check this. But making sure it doesnt crash on corner cases would be useful definitely :) |
|
This one is fine to merge from my side |
karasikov
pushed a commit
to karasikov/shogun
that referenced
this pull request
Apr 15, 2017
Fix wrong behaviour of SGIO::progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3509.
SG_PROGRESS current behaviour:
SG_PROGRESS patch behaviour: