Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete all VW code #4030

Closed
karlnapf opened this issue Dec 17, 2017 · 2 comments
Closed

delete all VW code #4030

karlnapf opened this issue Dec 17, 2017 · 2 comments
Labels
good first issue Tag: Cleanup

Comments

@karlnapf
Copy link
Member

Delete all VW code in shogun src/shogun/classifier/vw/

Then make sure the build still works

  • delete all tests
  • delete all examples

Run tests and send PR, all fine
@salonirk11
Copy link
Contributor

@karlnapf Can I work on this issue?

@vigsterkr
Copy link
Member

@salonirk11 yes, certainly. make sure that before you send in a PR both all the examples and tests are passing on your machine locally.

salonirk11 added a commit to salonirk11/shogun that referenced this issue Dec 22, 2017
@salonirk11
Fixes shogun-toolbox#4030
1111cc8
@salonirk11 salonirk11 mentioned this issue Dec 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Tag: Cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vigsterkr @karlnapf @salonirk11