Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CartTree is not clonable #4089

Closed
rahul13ramesh opened this issue Jan 19, 2018 · 4 comments
Closed

CartTree is not clonable #4089

rahul13ramesh opened this issue Jan 19, 2018 · 4 comments

Comments

@rahul13ramesh
Copy link

CrossValidation with CartTree() results in a systemError. In particular, when one calls the evaluate function of a CrossValidation object, the error occurs.

Here is the complete script(with log file) that highlights the issue.
https://gist.github.com/Red-devilz/4b2c6cdc361bf4dcd5e5dc50b8ff3eef

The error is as follows :

SystemError: [ERROR] In file /build/shogun-V6YrEn/shogun-6.1.3/src/shogun/base/SGObject.cpp line 744: 
Could not create empty instance of "BinaryTreeMachineNode". The reason for this usually is that get_name() of the 
class returns something wrong, or that a class has a wrongly set generic type.

I believe the error occurs at this line but I could be wrong. An identical error affects StratifiedCrossValidation() also.

@karlnapf
Copy link
Member

karlnapf commented Jan 20, 2018

You are probably right. This means our random forests are not clonable. It has nothing to do with crossvalidation actually.

@karlnapf karlnapf changed the title CrossValidation fails with CartTree CartTree is not clonable Jan 20, 2018
@karlnapf
Copy link
Member

Actually I don't even understand why that clone is there in xvalidation. We removed the multicore version a while ago due to problems, so no clone is needed. puzzled. @vigsterkr any comments?

@stale
Copy link

stale bot commented Feb 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 26, 2020
@vigsterkr
Copy link
Member

this done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants