Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning ipython notebooks. removing non-scipy stack dependencies #4091

Closed
wants to merge 9 commits into from
Closed

Cleaning ipython notebooks. removing non-scipy stack dependencies #4091

wants to merge 9 commits into from

Conversation

rahul13ramesh
Copy link

@rahul13ramesh rahul13ramesh commented Jan 19, 2018

Cleaned ipython notebooks, which involved the following changes

  • Changed modshogun -> shogun, changed imports to import shogun as sg, instead of from shogun import *
  • Changed code to conform to PEP8 python format
  • Removed pylab and pillow.Image imports
  • Used try-except clause, to smoothly execute imports(cv2, networkx, sklearn) that cannot be removed
  • Replace couple of dead-url's ( Full list here )

Other file specific changes

  • HashedDocDotFeatures.ipynb - Try-Except clause around MKLClassification(needs SVM light to execute)
  • MKL.ipynb - Changed color to plot, to green to distinguis colour
  • xval_modelselection.ipynb - Added mplot3d
  • gaussian_processes.ipynb - moved legend location, for better plot visibility
  • Scene_classification.ipynb - Fixed cv2, error due to change in API in new cv2 verion
  • multilabel_structured_prediction.ipynb - Fixed error in sklearn, due to change in API

The only notebook that executes with errors is multiclass/tree/DecisionTrees.ipynb, possibly due to #4089. This has been left as is, since it could be a shogun bug

@karlnapf
Copy link
Member

This is great! Thanks for the patch.
I have one (annoying) re-structuring request: Could you send a PR where you store all those notebooks in your new format without doing any changes first? The diff is totally useless otherwise, and I cannot read through all of the notebooks in source code. Make sure to not loose your changes when doing this :)

@karlnapf
Copy link
Member

@iglesias now your notebook preview builder would be handy ;)

@rahul13ramesh
Copy link
Author

Sure, I'm on it. Just to clarify, you want a separate PR, right? The first commit involves no changes to code(just changing ipython v3 -> v4) Then perhaps a commit changing indentation, formatting, extra spaces and last few commits changing code.

@vigsterkr
Copy link
Member

@red-devilz yeah indeed the idea is that we somehow separate automated changes - see v3->v4 - from actual code change, i.e. bug fixes

@karlnapf
Copy link
Member

Any updates?

@stale
Copy link

stale bot commented Feb 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 26, 2020
@stale
Copy link

stale bot commented Mar 4, 2020

This issue is now being closed due to a lack of activity. Feel free to reopen it.

@stale stale bot closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants