Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port meta examples to new API #4247

Closed
karlnapf opened this issue Apr 13, 2018 · 2 comments
Closed

port meta examples to new API #4247

karlnapf opened this issue Apr 13, 2018 · 2 comments
Labels
good first issue Tag: Meta Examples
Milestone
Shogun 7.0.0

Comments

@karlnapf
Copy link
Member

karlnapf commented Apr 13, 2018 •
edited

All meta examples should

  • use the generic put and get methods rather than custom getters setters
  • use factory methods, instead of parametrised constructors, to create new objects, load files, etc (and subsequent put/get calls). Pls use the kwargs feature (see meta_api/kwargs.sg
  • dont use types apart from the base types: Machine, Kernel, Labels (not RegressionLabels, etc), Features

See https://github.com/shogun-toolbox/shogun/blob/develop/examples/meta/src/binary/kernel_support_vector_machine.sg for a fully ported example

Note that this might involve creating new factory methods.
@shubham808 shubham808 mentioned this issue May 4, 2018
Merged
karlnapf pushed a commit that referenced this issue May 7, 2018
@shubham808 @karlnapf
factory methods in lda meta example #4247 (#4236)
18cf07f 
* factory methods in lda
* some-ize lda unit test
* data update
@karlnapf
Copy link
Member Author

This is still open, there are still some

  • constructor calls ( to be replaced by factory calls)
  • specialized method calls (should be refactored to put/get or otherwise)

@karlnapf karlnapf added this to the Shogun 7.0.0 milestone Jan 13, 2019
ktiefe pushed a commit to ktiefe/shogun that referenced this issue Jul 30, 2019
@shubham808 @ktiefe
factory methods in lda meta example shogun-toolbox#4247 (shogun-toolb…
3eff478 
…ox#4236)

* factory methods in lda
* some-ize lda unit test
* data update
@karlnapf
Copy link
Member Author

I think this should be almost done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Tag: Meta Examples
Projects
None yet
Milestone
Shogun 7.0.0
Development

No branches or pull requests
1 participant
@karlnapf