Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't compile with Eigen < 3.3.3 #4288

Closed
micmn opened this issue May 17, 2018 · 1 comment
Closed

Can't compile with Eigen < 3.3.3 #4288

micmn opened this issue May 17, 2018 · 1 comment

Comments

@micmn
Copy link
Contributor

micmn commented May 17, 2018

Stan's perceptron unit test fails to compile with Eigen 3.2.92:
StanMath/stan/math/rev/mat/fun/Eigen_NumTraits.hpp:297:54: error: wrong number of template arguments (6, should be at least 8) (full log)
I guess it's due to the fact that Stan requires Eigen 3.3.3 whereas Shogun's minimum requirements is 3.1.2
@micmn micmn changed the title Can't compile with Eigen < 3.3 Can't compile with Eigen < 3.3.3 May 17, 2018
@vigsterkr
Copy link
Member

miju :) since we can bundle eigen and afaik Stan actually has a 3.3.3 bundled eigen, i reckon the best would be just to drop as is the whole system detection of eigen and use Stan's eigen bundled.... @FaroukY

ktiefe pushed a commit to ktiefe/shogun that referenced this issue Jul 30, 2019
@vigsterkr @ktiefe
Always use Stan's eigen fix shogun-toolbox#4288
ecd9fc1 
remove optional system dependency to eigen as we anyways have eigen internally
available due to Stan dependency
vigsterkr added a commit to vigsterkr/shogun that referenced this issue Feb 27, 2020
@vigsterkr
Revert "Always use Stan's eigen fix shogun-toolbox#4288"
d348c69 
This reverts commit eca71c6.
vigsterkr added a commit that referenced this issue Feb 27, 2020
@vigsterkr
Revert "Always use Stan's eigen fix #4288"
2565343 
This reverts commit eca71c6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vigsterkr @micmn