Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup web pages #4512

Closed
9 of 10 tasks
p16i opened this issue Feb 4, 2019 · 4 comments
Closed
9 of 10 tasks

Cleanup web pages #4512

p16i opened this issue Feb 4, 2019 · 4 comments

Comments

@p16i
Copy link
Contributor

p16i commented Feb 4, 2019 •
edited

Hi Shogun Team,

I'm Pat, I'm a student from TU Berlin. I plan to participate in GSoC 2019 under Shogun. While reading pages on shogun.ml, I've found several problems on the web pages. These problems include dead links, outdated commands, and improper rendering.

I'll take a look on these problems and prepare PRs, and please let me know if you have comments or know other related issues.

Page : http://shogun.ml/mission

  • Dead links:

    1. Maybe change it to Google's Colab? image

    2. screenshot 2019-02-04 13 24 54

Page : http://shogun.ml/examples/latest/index.html

  • Dead links:

    1. image

    2. image

  • JS Errors (MathJax)
    screenshot 2019-02-04 13 35 42
  • Error in MathJax commands solved by above.
    screenshot 2019-02-04 13 38 06
    screenshot 2019-02-04 13 38 21
    screenshot 2019-02-04 13 44 58
  • Empty code cell fixed on develop
    screenshot 2019-02-04 13 39 52
  • Reference Section displays oddly.
    Current
    screenshot 2019-02-04 14 27 51
    Suggestion Remove display: inline; font-size: 75% from class `label.
    screenshot 2019-02-04 14 28 16

Page : http://shogun.ml/install

  • Dead links:

    1. image
    2. image
      UPDATED: We don't have the apt server at the moment (mentioned in Cleanup web pages  #4512 (comment)). So, I will leave this one as it is for now.
    3. image

    The page doesn't show any meaningful information, just a default page.

  • Homebrew/science has been deprecated and shogun has been included in Homebrew's core formulae. As a result, we need to change the brew command to

brew install shogun
  • Duplicate import statements for shogun-style.css.
    image

Page: http://shogun.ml/showroom

  • Modal view looks odd. Please see the screenshot below. I think we can just redirect the link to where those notebooks are hosted and get rid of the modal view.
    image

Shogun HTTPS Certificate

Shogun's HTTPS certificate was expired. I'm not sure whether we need to fix it. In case this issue is relevant, maybe we can consider using Let's encrpyt.
image
@karlnapf
Copy link
Member

karlnapf commented Feb 5, 2019

Thanks for reporting those. We are more than happy for direct edits to the wiki (it is public), PRs for the examples/cookbooks, and PRs to the website repository

p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Remove the link to the old team page.
a121b7f 
Fix shogun-toolbox#4512.
p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Fix deadlinks in INTERFACES.md
f5c6976 
For shogun-toolbox#4512
p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Use inline script tag for custom LaTeX commands. (shogun-toolbox#4512)
4413403 
Previoulsy, we load MathJax and mathconfig.js asynchronously. This is
not good for mathconfig.js because it requires the main variable for
MathJax.js.
p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Fix style of reference section. (shogun-toolbox#4512)
0b6b454 
Note: the problem seems to originally come from boostrap and how
our biblatex plugin uses `label class` to generates reference entries.
p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Update links and some installation information. (shogun-toolbox#4512)
de62d3b 
The information includes Docker and MacOS brew installation.
p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Remove duplicated years in references.bib. (shogun-toolbox#4512)
84bca4a 
"Gaussian Processes for Machine Learning" has duplicate years and causes
an error when generating the cookbook webpages. According to the book's
webpage, the published year is 2006.
p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Remove duplicate import statements for shogun-style.css (shogun-toolb…
42a990a 
…ox#4512).
p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Update links and some installation information. (shogun-toolbox#4512)
fd19449 
The information includes Docker and MacOS brew installation.
p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Remove duplicated years in references.bib. (shogun-toolbox#4512)
84b331a 
"Gaussian Processes for Machine Learning" has duplicate years and causes
an error when generating the cookbook webpages. According to the book's
webpage, the published year is 2006.
p16i added a commit to p16i/shogun that referenced this issue Feb 7, 2019
@p16i
Remove duplicate import statements for shogun-style.css (shogun-toolb…
50f3f96 
…ox#4512).
@p16i p16i mentioned this issue Feb 7, 2019
Merged
@p16i
Copy link
Contributor Author

p16i commented Feb 7, 2019 •
edited

@karlnapf I've created a PR (#4516) containing patches for these issues.
Noting, I haven't updated the Debian installation yet because I'm not sure whether Shogun still has its own APT server. Could you please confirm? Otherwise, I'll just update the section with information from https://packages.debian.org.

Should I create two new issues for fixing showroom pages and https as they might require further discussion. What do you think?

@karlnapf
Copy link
Member

karlnapf commented Feb 8, 2019

no own apt server
debian packages are not up to the latest iirc....need to check. We have some ubuntu packages but not the latest....we always struggle to find people helping with the packaging in fact if you are looking for something to help :)
I would leave the showroom for now as we are in the progress of updating the website again, so this should change soon

@p16i
Copy link
Contributor Author

p16i commented Feb 11, 2019

@karlnapf I can help you with Debian and Ubuntu packaging.

p16i added a commit to p16i/shogun that referenced this issue Feb 12, 2019
@p16i
Revert "Use inline script tag for custom LaTeX commands. (shogun-tool…
a4971bf 
…box#4512)"

This reverts commit 4413403.
p16i added a commit to p16i/shogun that referenced this issue Feb 12, 2019
@p16i
set mathjax configuration using window.MathJax (shogun-toolbox#4512)
866d36c
p16i added a commit to p16i/shogun that referenced this issue Feb 12, 2019
@p16i
use relative urls for links to documents. (shogun-toolbox#4512)
0935e95
vigsterkr pushed a commit to vigsterkr/shogun that referenced this issue Mar 9, 2019
@p16i @vigsterkr
Cleanup broken links and fix some issues on Shogun's webpages. (shogu…
76c54f1 
…n-toolbox#4516)

* Remove the link to the old team page.

Fix shogun-toolbox#4512.

* Fix deadlinks in INTERFACES.md

For shogun-toolbox#4512

* Use inline script tag for custom LaTeX commands. (shogun-toolbox#4512)

Previoulsy, we load MathJax and mathconfig.js asynchronously. This is
not good for mathconfig.js because it requires the main variable for
MathJax.js.

* Fix style of reference section. (shogun-toolbox#4512)

Note: the problem seems to originally come from boostrap and how
our biblatex plugin uses `label class` to generates reference entries.

* Update links and some installation information. (shogun-toolbox#4512)

The information includes Docker and MacOS brew installation.

* Remove duplicated years in references.bib. (shogun-toolbox#4512)

"Gaussian Processes for Machine Learning" has duplicate years and causes
an error when generating the cookbook webpages. According to the book's
webpage, the published year is 2006.

* Remove duplicate import statements for shogun-style.css (shogun-toolbox#4512).

* Revert "Use inline script tag for custom LaTeX commands. (shogun-toolbox#4512)"

This reverts commit 4413403.

* set mathjax configuration using window.MathJax (shogun-toolbox#4512)

* use relative urls for links to documents. (shogun-toolbox#4512)
karlnapf pushed a commit that referenced this issue Jul 5, 2019
@p16i @karlnapf
Cleanup broken links and fix some issues on Shogun's webpages. (#4516)
7536fe9 
* Remove the link to the old team page.

Fix #4512.

* Fix deadlinks in INTERFACES.md

For #4512

* Use inline script tag for custom LaTeX commands. (#4512)

Previoulsy, we load MathJax and mathconfig.js asynchronously. This is
not good for mathconfig.js because it requires the main variable for
MathJax.js.

* Fix style of reference section. (#4512)

Note: the problem seems to originally come from boostrap and how
our biblatex plugin uses `label class` to generates reference entries.

* Update links and some installation information. (#4512)

The information includes Docker and MacOS brew installation.

* Remove duplicated years in references.bib. (#4512)

"Gaussian Processes for Machine Learning" has duplicate years and causes
an error when generating the cookbook webpages. According to the book's
webpage, the published year is 2006.

* Remove duplicate import statements for shogun-style.css (#4512).

* Revert "Use inline script tag for custom LaTeX commands. (#4512)"

This reverts commit 4413403.

* set mathjax configuration using window.MathJax (#4512)

* use relative urls for links to documents. (#4512)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karlnapf @p16i