Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for continuous features with the HM-SVM using PLiFs #1089

Merged
merged 3 commits into from Jun 3, 2013

Conversation

iglesias
Copy link
Collaborator

No description provided.

template <class T>
SGVector<float64_t> SGVector<T>::linspace_vec(T start, T end, int32_t n)
{
return SGVector<float64_t>(linspace(start, end, n), n);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a unit test for those would be great!

@karlnapf
Copy link
Member

Hi!
To be honest, I have no idea what this code is doing, but it looks good. :)
I suggest to add some unit tests that cover new/modified parts. Just recycle your local tests.
Examples are already in, nice! Travis should not without you having modified the integration tests in the data repository. Since you changed the examples anyway, you have to re-create tests which is nice because you can change SG_ADD parameters on the fly

- Major changes in HMSVMModel
- Add convenience init_training method in StructuredModel
- TwoStateModel::simulate_two_state_data -> simulate_data with arguments
- Fix bug with default value of m_use_director_risk in StructuredModel cto.
iglesias added a commit that referenced this pull request Jun 3, 2013
Support for continuous features with the HM-SVM using PLiFs
@iglesias iglesias merged commit 923f9b3 into shogun-toolbox:develop Jun 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants