Added check of standard deviation (m_sigma) in GP likelihoods #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heh - standard 🐹 |
|
Ah, sure. I'll fix it now, i'm just confused a little bit :) |
| } | ||
|
|
||
| void CGaussianLikelihood::init() | ||
| void CGaussianLikelihood::init(float64_t sigma) |
There was a problem hiding this comment.
Ah I now understand what you had in mind here.
I would do this slightly differently: the init method should not have any parameters, just private void init()
It initialises with default values and registers parameters.
However, the constructors should have the REQUIRE checks, they are called by the user, so please do the checks in there.
There was a problem hiding this comment.
Yes, I agree with you, it will be more informative.
sonney2k
pushed a commit
that referenced
this pull request
May 23, 2013
Added check of standard deviation (m_sigma) in GP likelihoods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.