System-wide installed gmock is not detected by configure script. #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k for /usr/include/gmock/ should not depend on $GMOCK_DIR/src/gmock-all.cc.
|
the problem is that we NEED gmock sources just as in case of gtest. hence, having only the header with precompiled shared/static libraries are not enough. see: |
|
@vigsterkr maybe you add a warning in configure pointing to this link if we don't find the sources but only the binaries? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for /usr/include/gmock/ should not depend on $GMOCK_DIR/src/gmock-all.cc.
i.e. check for systems /usr/include/gmock/ was nested into check for local check $GMOCK_DIR - just moved the check outside.