ptype complex64_t added #1140
Merged
ptype complex64_t added #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lambday
commented
Jun 3, 2013
lambday
commented
- complex64_t datatype added, with (only required) support for Math, SGVector, SGMatrix, SGSparseVector, SGSparseMatrix
- two methods added in SGVector, get_real() and get_imag(), for complex64_t
- two unit tests added, for Math complex functions and SGVector complex
| @@ -1738,6 +1817,11 @@ void Parameter::add(SGMatrix<SGSparseVector<floatmax_t> >* param, | |||
| SG_FREE(*(SGString<float64_t>**) m_parameter); break; | |||
| case PT_FLOATMAX: | |||
| SG_FREE(*(SGString<floatmax_t>**) m_parameter); break; | |||
| case PT_COMPLEX64: | |||
| SG_SERROR("TParameter::delete_cont(): Implementation " | |||
There was a problem hiding this comment.
@karlnapf I haven't added support for SGString<complex64_t>, that's why kept anything related to SGString<complex64_t> this way. Shall I add it?
There was a problem hiding this comment.
No you dont have to add it, but please change the error message to "Parameters of strings of complex64_t are not supported"
|
wow, nice patch and a lot of stuff The parameter things should be carefully unit-tested (best with serialisation) |
|
@karlnapf thanks. I'm working on the parameter unit-tests for complex. Will add soon. |
| static inline float64_t sinh(float64_t x) | ||
| { | ||
| return ::asinh(x); | ||
| return ::asinh(x); //TODO is this correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.