Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added special make targets to allow builds without installing them. #1301

Merged
merged 1 commit into from Jul 25, 2013

Conversation

tklein23
Copy link
Contributor

Just call: $ make {install,tests,check-examples,run-testsuite}-local-build clean-local-build

Just call: $ make {install,tests,check-examples,run-testsuite}-local-build clean-local-build
@sonney2k
Copy link
Member

pure magic!

sonney2k pushed a commit that referenced this pull request Jul 25, 2013
Added special make targets to allow builds without installing them.
@sonney2k sonney2k merged commit 7d5f236 into shogun-toolbox:develop Jul 25, 2013
@karlnapf
Copy link
Member

nice waiting for that! thanks :)

@tklein23
Copy link
Contributor Author

@sonney2k: Could be even more magic (or idiomatic?) if I

  • renamed make target "install-local-build" to "install-local"
  • renamed directory "local-build-tmp" to "install-local"
install-local:
   $(MAKE) DESTDIR="$(shell readlink -f ".")"/$@ install

clean-local:
   @rm -rf install-local

%-local: install-local
   $(MAKE) DESTDIR="$(shell readlink -f ".")"/$< $*

But then the connection between the directory and the target would become {less obvious, more magic}.

Just curious: Any thoughts on this? More/less readable/idiomatic/error-prone/...?

@tklein23 tklein23 deleted the allow_builds_in_src_tree branch July 25, 2013 11:56
@sonney2k
Copy link
Member

yeah local would be good enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants