Pranet dev

[pranet]

Proper comparison of floating point values in equals method #1888

[iglesias]

Apologize if I am missing something obvious, but I don't quite get why commenting the abs method?

[iglesias]

Is there any difference between these two below in order to compute the absolute value?

else if (a>0)
      return a;
else
      return -a;

and

else if (a<0)
      return -a;
else
      return a;

[dhruv13J]

This patch also fails to call the new function from within the TParameter::compare_ptype() function... I will submit my patch soon

[pranet]

Hi,
@iglesias
This was what I had in mind when I commented out the zero. I may have been wrong though...The intention was to avoid direct comparison with zero
http://stackoverflow.com/questions/2378628/can-you-compare-floating-point-values-exactly-to-zero

@dhruv13J
I completely missed that part . I'll try again

[iglesias]

All right @pranet, I get it now. Thanks for the clarification!

[pranet]

And how do I call the new function from TParameter::compare_ptype()? Do I have to use the existing one , or am I allowed to overload it as a template?

[dhruv13J]

@pranet: check this - #1896

[pranet]

I see. thanks!

[karlnapf]

I guess this one is redundant to #1896, so I am closing it for now