Clean unittest imports #2011
Merged
Clean unittest imports #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow thats great! I guess you did this by hand? No automagic way? :) |
|
I used static code analysis and it was suggesting "diffs" on how to change the sources. The automagical fix would do too much... consider this one to be a proof-of-concept and later we can check how to improve. |
|
Maybe we get something similar with clangs next release, so we see it in the static analysis. |
tklein23
added a commit
that referenced
this pull request
Mar 16, 2014
Clean unittest imports (removed obsolete imports as a first step)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our unit tests are doing a lot of obsolete #include's.
I used static code analysis to find #include problems, but I only chose to remove obsolete imports. It's only a first step, but it could become even cleaner if we repeat this step.
See my attached commits for cleaner unit tests.