Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming_onlineliblinear_sparse.cpp: Use mktemp in example #2052

Merged
merged 1 commit into from Mar 20, 2014
Merged

streaming_onlineliblinear_sparse.cpp: Use mktemp in example #2052

merged 1 commit into from Mar 20, 2014

Conversation

vperic
Copy link
Contributor

@vperic vperic commented Mar 20, 2014

Instead of creating a new file, which then dirtied the "data" submodule
repository, create a temporary file with "mktemp()", as used elsewhere.

Instead of creating a new file, which then dirtied the "data" submodule
repository, create a temporary file with "mktemp()", as used elsewhere.
tklein23 added a commit that referenced this pull request Mar 20, 2014
streaming_onlineliblinear_sparse.cpp: Use mktemp in example
@tklein23 tklein23 merged commit 1f24f77 into shogun-toolbox:develop Mar 20, 2014
@tklein23
Copy link
Contributor

Thanks a lot!

@tklein23
Copy link
Contributor

@vperic - can you check if the memory is freed properly? For me it looks like test_labels_file_name doesn't get freed.

A simple way to check this would be:
valgrind --leak-check=full ./the-example-to-check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants