Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting changes in data to fix broken build on develop #2330

Merged
merged 1 commit into from
Jun 25, 2014

Conversation

lambday
Copy link
Member

@lambday lambday commented Jun 23, 2014

No description provided.

@lambday
Copy link
Member Author

lambday commented Jun 23, 2014

@karlnapf restarted the build. If this goes green on travis then its ready to merged. Locally the mmd tests are working with this data on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling 51f2257 on lambday:develop into 44db60e on shogun-toolbox:develop.

@lambday
Copy link
Member Author

lambday commented Jun 23, 2014

@besser82 yeah but I don't have any clue about that :( this was failing
earlier also. I only made changes for the failures that were caused by my
earlier commit!

On Mon, Jun 23, 2014 at 4:49 PM, Björn Esser notifications@github.com
wrote:

@lambday https://github.com/lambday looks like there is still a fail
caused by misalignment in
integration-python_modular-tester-classifier_multiclasslibsvm_modular


Reply to this email directly or view it on GitHub
#2330 (comment)
.

Regards,
Rahul
+918879426396

@karlnapf
Copy link
Member

Okay. Does this test fail locally? If not, compare the data version, if yes, quickly double check whether results are sensible and then just update integration test file. Best thing in fact would be to identify the PR that first broke this - though some work as hidden in red travis.

You see, this is the reason to keep the build green, things slip through otherwise.

@lambday
Copy link
Member Author

lambday commented Jun 24, 2014

@karlnapf actually some other tests are failing locally as well. Anyway I regenerated the data. The values seem sensible. After I updated the data locally, the failure for this particular test seems to be gone.

The following tests FAILED:
    115 - integration-python_modular-tester-multiclass_c45classifiertree_modular (Failed)
    132 - integration-python_modular-tester-multiclass_chaidtree_modular (Failed)
    138 - integration-python_modular-tester-multiclass_cartree_modular (Failed)
    159 - integration-python_modular-tester-regression_chaidtree_modular (Failed)
    164 - integration-python_modular-tester-multiclass_randomforest_modular (Failed)
    238 - integration-python_modular-tester-regression_cartree_modular (Failed)
    315 - integration-python_modular-tester-regression_randomforest_modular (Failed)
    322 - integration-python_modular-tester-multiclass_id3classifiertree_modular (Failed)

Sending a data PR.

@lambday
Copy link
Member Author

lambday commented Jun 24, 2014

@karlnapf restarting the travis build! fingers crossed!

@lambday
Copy link
Member Author

lambday commented Jun 24, 2014

@karlnapf travis is green again :) merging! :)

@lambday
Copy link
Member Author

lambday commented Jun 24, 2014

On second thought, on buildbot, only the mmd tests were failing! So I'll wait for you to review this and then merge!

@karlnapf
Copy link
Member

Note that re-generating data is not the way to fix broken tests. That should only be done when the class is changed. But Ill merge for now since then we are green again!

karlnapf added a commit that referenced this pull request Jun 25, 2014
Reverting changes in data to fix broken build on develop
@karlnapf karlnapf merged commit 4c9c918 into shogun-toolbox:develop Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants