-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverting changes in data to fix broken build on develop #2330
Conversation
@karlnapf restarted the build. If this goes green on travis then its ready to merged. Locally the mmd tests are working with this data on develop. |
@besser82 yeah but I don't have any clue about that :( this was failing On Mon, Jun 23, 2014 at 4:49 PM, Björn Esser notifications@github.com
Regards, |
Okay. Does this test fail locally? If not, compare the data version, if yes, quickly double check whether results are sensible and then just update integration test file. Best thing in fact would be to identify the PR that first broke this - though some work as hidden in red travis. You see, this is the reason to keep the build green, things slip through otherwise. |
@karlnapf actually some other tests are failing locally as well. Anyway I regenerated the data. The values seem sensible. After I updated the data locally, the failure for this particular test seems to be gone.
Sending a data PR. |
@karlnapf restarting the travis build! fingers crossed! |
@karlnapf travis is green again :) merging! :) |
On second thought, on buildbot, only the mmd tests were failing! So I'll wait for you to review this and then merge! |
Note that re-generating data is not the way to fix broken tests. That should only be done when the class is changed. But Ill merge for now since then we are green again! |
Reverting changes in data to fix broken build on develop
No description provided.