update the lbfgs optimizer #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling c3f908e on yorkerlin:develop into * on shogun-toolbox:develop*. |
| @@ -391,6 +391,31 @@ typedef int (*lbfgs_progress_t)( | |||
| int ls | |||
| ); | |||
|
|
|||
| /** | |||
| * Callback interface to adjust step size based on constrains. | |||
|
Very nice! |
| const float64_t strict_scale=1e-5; | ||
|
|
||
| //Init the parameters used for L-BFGS | ||
| lbfgs_parameter_t inti_lbfgs_parameters() |
|
@karlnapf |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@karlnapf
Please merge this first.
I will send additional two PRs for dual likelihoods and dual KL method respectively once this is merged.