replaced SGVector::scale() with linalg::scale() #2928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +38,7 @@ SGVector<float64_t> CMeanRule::combine(const SGMatrix<float64_t>& ensemble_resul | |||
| SGVector<float64_t> mean_labels(row_sum, ensemble_result.num_rows); | |||
|
|
|||
| float64_t scale = 1/(float64_t)ensemble_result.num_cols; | |||
| mean_labels.scale(scale); | |||
| linalg::scale<linalg::Backend::NATIVE>(mean_labels, scale); | |||
There was a problem hiding this comment.
you have already written using namespace linalg, so you can omit the linalg:: here I suppose.
There was a problem hiding this comment.
Fixed. linalg:: was necessary to avoid names conflist with float64_t scale.
|
Hi @nginn. Thanks for the patch! It looks good. Please see my minor comments. We can merge it once you address those. |
added 6 commits
November 5, 2015 23:00
Conflicts: src/shogun/machine/gp/EPInferenceMethod.cpp
…GVector) to .cpp file; added benchmark for SGVector::operator+=(SGVector)
|
updates here? |
| template<class T> | ||
| SGVector<T> SGVector<T>::operator+= (SGVector<T> x) | ||
| { | ||
| linalg::add<linalg::Backend::NATIVE>(*this, x, *this); |
There was a problem hiding this comment.
what is the a reason for NATIVE here?
|
can you remove the NATIVE, and just use the default backend (is set to eigen3 these days) |
| @@ -25,6 +25,7 @@ | |||
| #include <algorithm> | |||
|
|
|||
| #include <shogun/mathematics/eigen3.h> | |||
| #include <shogun/mathematics/linalg/linalg.h> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the first part of the issue #2717