New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eigen3 correction #3063
eigen3 correction #3063
Conversation
ELSE () | ||
MESSAGE("-- Supported backend(s) for linear algebra NOT FOUND/NOT ENABLED") | ||
ENDIF () | ||
SET(HAVE_LINALG_LIB 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HAVE_LINALG was not enabled previously, which was an error
The viennaCL buildbot requires to change |
fix and clean up eigen 3 options
c566c8e
to
4db4dca
Compare
@karlnapf any reason why not to merge this? |
needs a buildbot change, see comment above. I would prefer this. |
i've merged and updated the buildbot params for the viennacl job, i'm getting the following output from cmake
@karlnapf why Eigen3 is still the eigen solver module? |
This has to be fixed |
I guess this can wait until we re-structure no? |
@vigsterkr UPDATE: I applied the fix to develop as it is definitely necessary. The rest is optional for cleaner cmake options.
I renamed them to start with LINALG_ so that they are grouped if ppl check the options and not scattered all over without it being clear that they change linag behaviour. Also, ccmake which shows the cached options now does't show a binary ON/OFF, but the string. Just like CMAKE_BUILD_TYPE
This might interfere with some builds. Let me know