Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eigen3 correction #3063

Merged

Conversation

karlnapf
Copy link
Member

@vigsterkr UPDATE: I applied the fix to develop as it is definitely necessary. The rest is optional for cleaner cmake options.

I renamed them to start with LINALG_ so that they are grouped if ppl check the options and not scattered all over without it being clear that they change linag behaviour. Also, ccmake which shows the cached options now does't show a binary ON/OFF, but the string. Just like CMAKE_BUILD_TYPE

This might interfere with some builds. Let me know

ELSE ()
MESSAGE("-- Supported backend(s) for linear algebra NOT FOUND/NOT ENABLED")
ENDIF ()
SET(HAVE_LINALG_LIB 1)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAVE_LINALG was not enabled previously, which was an error

@karlnapf
Copy link
Member Author

The viennaCL buildbot requires to change DLinAlgBackend=VIENNACL to DLINALG_DEFAULT_BACKEND=VIENNACL

fix and clean up eigen 3 options
@vigsterkr
Copy link
Member

@karlnapf any reason why not to merge this?

@karlnapf
Copy link
Member Author

needs a buildbot change, see comment above. I would prefer this.
Not important as it is refactored anyways. Merge if it is easy to change buildbot scripts, otherwise just close

@vigsterkr vigsterkr merged commit 0a66028 into shogun-toolbox:develop May 19, 2016
@vigsterkr
Copy link
Member

i've merged and updated the buildbot params for the viennacl job, i'm getting the following output from cmake

-- ViennaCL set as default global linear algebra backend library
-- Eigen3 set as default core module (linalg) backend library
-- Eigen3 set as default reduction module (linalg) backend library
-- Eigen3 set as default eigen solver module (linalg) backend library

@karlnapf why Eigen3 is still the eigen solver module?

@karlnapf
Copy link
Member Author

This has to be fixed

@karlnapf
Copy link
Member Author

I guess this can wait until we re-structure no?

@karlnapf karlnapf deleted the feature/eigen3_correction branch May 28, 2016 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants