-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kmeans page to cookbook #3183
Conversation
Some general issues -
|
@OXPHOS I will take a look at ctags issue. This was actually caused by me. |
|
@lisitsyn Hey the error message is interestingly different from the last time I submitted but I guess it still has something to do with Please see below for details. Thanks!
|
dcc6aed
to
2f7f73f
Compare
@@ -0,0 +1,47 @@ | |||
================== | |||
:math:`k`-means clustering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minors: Capital K please. Also, can you avoid the math in the header (only there)
Error:
|
Interesting. Can you reproduce this locally? |
I did Also I tried python modular and they failed too. Did I miss anything? |
What error are they failing on? |
You can also run the meta examples manually. What happens then? |
I don't think any specific info is provided. Do you mind showing me how to run meta example manually? Thanks. Run
|
Just run the generated code listing or compiled binary from its directory On Thursday, 19 May 2016, OXPHOS notifications@github.com wrote:
Sent from my phone |
Aha @karlnapf If this is what you refer to -
|
That is weird. Is it the same error as you get on travis? |
@karlnapf So I tried both make install and add path.
|
Can we discuss this in another thread? |
@karlnapf This should be moved to clustering as well. What do you think of the ruby issue? You want to open a new thread for it? |
Yes move it! |
Ill just use this version to check now |
@karlnapf yes this is the version gives problems. thx. |
|
||
---------- | ||
References | ||
---------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add david barbers book as reference as well?
Ok travis failure is from gmm. As soon as the minor adjustments in the rst are made, we can (finally!) merge :) |
@karlnapf can check again :) |
The R is also failing.. |
In other words, its objective is to minimize: | ||
|
||
.. math:: | ||
x\argmin_\mathbf{S} \sum_{i=1}^{k}\sum_{\mathbf{x}\in S_k}\left \|\boldsymbol{x} - \boldsymbol{\mu}_i \right \|^{2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this x in the beginning should not be there :)
Some minor adjustments are needed. A rebase against develop should make travis happy (I disabled R meta examples) |
435a0cb
to
5956565
Compare
@karlnapf I tried ~30 times on local and the test can be passed, but it keeps failing on travis..So I'll put |
fixed centers obviously changes the algorithm (and the integration test data) |
@karlnapf I updated the integration test shogun-toolbox/shogun-data#101 |
Merged :) |
98e01af
to
c3c2daa
Compare
Next time you squash: please put a meaningful commit message. |
Waiting for travis and then merging |
EDIT: |
Aaaand merging |
Add kmeans page to cookbook
CLabels
in classCKMeans
, so I can't find a way to useapply_*
,eval.evaluate
, so as to compare test and training dataset.CKMeans
cannot haveCLabels
- we can just label the clusters 1..N.fm_train_real.dat
andclassifier_binary__2d_linear_features_train.dat
but I think it doesn't really matter which one to use..?