Fix buildbot mathematics/ warnings #3185
Conversation
| @@ -55,6 +55,7 @@ namespace implementation | |||
| template <typename inputType> | |||
| struct int2float | |||
| { | |||
| /** orininal type **/ | |||
There was a problem hiding this comment.
this should just be swig/doxygen ignored
There was a problem hiding this comment.
Like:
#ifndef SWIG
/*..*/
template<..>
struct int2float {..}
#endif
?
There was a problem hiding this comment.
yep // SWIG should skip this part
|
Thats the way :) |
|
While it seems now the int2float structure is required : ( |
|
None of this should be required / or exposed to SWIG. It is all internal. |
|
@karlnapf May I ask why cookbook fails? |
|
No idea, this happened in another PR as well and @vigsterkr restarted it. But doesnt work here. |
|
@karlnapf it worked : / |
| using floatType = float64_t; | ||
| }; | ||
|
|
||
| #else |
There was a problem hiding this comment.
I am not sure I understand the logic of this preprocessor if then else.
Don't we just want to hide things from swig? Why the else case?
There was a problem hiding this comment.
@karlnapf aha sorry I missed this..Because int2float type is used in Redux.h and MeanEigen3.h several times as return type. If I hide int2float from SWIG, it's going to be undefined.
There was a problem hiding this comment.
Does cause a build error?
The SWIG #ifdefs are not really used in compilation mode, but only for the swig wrapper (that should not need this type anyways)
|
ping |
|
@karlnapf You were right about SWIG..Should be ready now |
|
Thanks! |
Is this the correct way to do it? -
Fixed documentation warnings in
mathematics/in http://buildbot.shogun-toolbox.org/builders/deb3%20-%20modular_interfaces/builds/2853