Fixes #3231 Cookbook generation error using Sphinx from PyPI. #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine to merge from my side, but some cmake guru should also check |
|
Any update on this? Can my change be merged? Shogun requires a newer sphinx version for the templates, which is not found in the default location. For example on Ubuntu 14.04, shogun requires a Sphinx install from PyPI. Otherwise I have to rebase my cookbook pages against this PR every time to work on them and then undo the PR changes. |
|
thanks! |
karasikov
pushed a commit
to karasikov/shogun
that referenced
this pull request
Apr 15, 2017
Fixes shogun-toolbox#3231 Cookbook generation error using Sphinx from PyPI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3231 Cookbook generation error using Sphinx from PyPI.
Sphinx installed via PyPI resides in /usr/loca/bin